[Fix] Mark device config modified on org context change #1070

Modified OrganizationConfigSettings.save() to mark related device configs as modified
when the context (configuration variables) changes. This aligns with existing patterns
without altering device internals.

Fixes #1070

Author: stktyagi

openwisp_controller/config/apps.py

@@ -44,8 +44,6 @@ class ConfigConfig(AppConfig):
     default_auto_field = "django.db.models.AutoField"
 
     def ready(self, *args, **kwargs):
-        import openwisp_controller.config.signal_handlers  # noqa: F401
-
         self.__setmodels__()
         self.connect_signals()
         self.register_notification_types()

openwisp_controller/config/base/multitenancy.py

@@ -65,6 +65,11 @@ def save(
             bulk_invalidate_config_get_cached_checksum.delay(
                 {"device__organization_id": str(self.organization_id)}
             )
+            Device = swapper.load_model("config", "Device")
+            for device in Device.objects.filter(organization=self.organization):
+                if hasattr(device, "config") and device.config.status == "applied":
+                    device.config.set_status_modified()
+                    device.config.save()
 
 
 class AbstractOrganizationLimits(models.Model):

openwisp_controller/config/signal_handlers.py

@@ -887,20 +887,6 @@ def test_config_backend_changed(self):
                 self.assertTrue(d.config.templates.filter(pk=t2.pk).exists())
                 self.assertFalse(d.config.templates.filter(pk=t1.pk).exists())
 
-    def test_config_status_modification_on_change(self):
-        org = self._get_org()
-        device = Device.objects.create(name="orgtest-device", organization=org)
-        config = Config.objects.create(
-            device=device, status="applied", backend="netjsonconfig.OpenWrt", config={}
-        )
-        org_settings = OrganizationConfigSettings.objects.create(
-            organization=org, context={"ssid": "initial"}
-        )
-        org_settings.context = {"ssid": "changed"}
-        org_settings.save()
-        config.refresh_from_db()
-        self.assertEqual(config.status, "modified")
-
 
 class TestTransactionConfig(
     CreateConfigTemplateMixin,