[Fix] Resolve 500 FieldError on DeviceLocationView #1110 #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding organization_lookup = 'organization__in' to the view forces it to use the correct organization field and prevents the crash. Fixes #1110
nemesifier
requested changes
Oct 25, 2025
This test confirms the API correctly returns a 404 Not Found instead of crashing with a 500 FieldError. Fixes #1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding organization_lookup = 'organization__in' to the view forces it to use the correct organization field and prevents the crash.
Fixes #1110
Checklist
Reference to Existing Issue
Closes #1110
Description of Changes
The permission mixin was incorrectly using the child's organization path (content_object__organization) to filter the parent Device including organization_lookup = 'organization__in' to the view fixes it.