Skip to content

Commit 412c2ed

Browse files
committed
[fix] Updated system info to retrieve friendly OS identifiers #544
Added "distro" package as dependency. Fixes #544 (cherry picked from commit 738bae8)
1 parent 58e4d6a commit 412c2ed

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

openwisp_utils/admin_theme/system_info.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import sys
33
from collections import OrderedDict
44

5+
import distro
56
from django.conf import settings
67
from django.utils.module_loading import import_string
78

@@ -76,8 +77,11 @@ def get_enabled_openwisp_modules():
7677

7778
def get_os_details():
7879
uname = platform.uname()
80+
os_name = distro.name(pretty=True)
81+
# Simplify kernel version (e.g., "5.15.0-164-generic" -> "5.15.0")
82+
kernel_version = uname.release.split("-")[0]
7983
return {
80-
"os_version": uname.version,
81-
"kernel_version": uname.release,
84+
"os_version": os_name,
85+
"kernel_version": kernel_version,
8286
"hardware_platform": uname.machine,
8387
}

openwisp_utils/metric_collection/tests/__init__.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"openwisp-users": "1.1.0a",
44
}
55
_OS_DETAILS_RETURN_VALUE = {
6-
"kernel_version": "5.13.0-52-generic",
7-
"os_version": "#59~20.04.1-Ubuntu SMP Thu Jun 16 21:21:28 UTC 2022",
6+
"kernel_version": "5.13.0",
7+
"os_version": "Ubuntu 20.04.1 LTS",
88
"hardware_platform": "x86_64",
99
}
1010

@@ -39,7 +39,7 @@
3939
{
4040
"category": "Upgrade",
4141
"action": "kernel_version",
42-
"name": "5.13.0-52-generic",
42+
"name": "5.13.0",
4343
"value": 1,
4444
"times": 1,
4545
"period_start": 1701388800,
@@ -48,7 +48,7 @@
4848
{
4949
"category": "Upgrade",
5050
"action": "os_version",
51-
"name": "#59~20.04.1-Ubuntu SMP Thu Jun 16 21:21:28 UTC 2022",
51+
"name": "Ubuntu 20.04.1 LTS",
5252
"value": 1,
5353
"times": 1,
5454
"period_start": 1701388800,
@@ -105,7 +105,7 @@
105105
{
106106
"category": "Heartbeat",
107107
"action": "kernel_version",
108-
"name": "5.13.0-52-generic",
108+
"name": "5.13.0",
109109
"value": 1,
110110
"times": 1,
111111
"period_start": 1701388800,
@@ -114,7 +114,7 @@
114114
{
115115
"category": "Heartbeat",
116116
"action": "os_version",
117-
"name": "#59~20.04.1-Ubuntu SMP Thu Jun 16 21:21:28 UTC 2022",
117+
"name": "Ubuntu 20.04.1 LTS",
118118
"value": 1,
119119
"times": 1,
120120
"period_start": 1701388800,
@@ -170,7 +170,7 @@
170170
{
171171
"category": "Install",
172172
"action": "kernel_version",
173-
"name": "5.13.0-52-generic",
173+
"name": "5.13.0",
174174
"value": 1,
175175
"times": 1,
176176
"period_start": 1701388800,
@@ -179,7 +179,7 @@
179179
{
180180
"category": "Install",
181181
"action": "os_version",
182-
"name": "#59~20.04.1-Ubuntu SMP Thu Jun 16 21:21:28 UTC 2022",
182+
"name": "Ubuntu 20.04.1 LTS",
183183
"value": 1,
184184
"times": 1,
185185
"period_start": 1701388800,

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"swapper~=1.4.0",
3232
# allow wider range here to avoid interfering with other modules
3333
"urllib3>=2.0.0,<3.0.0",
34+
"distro~=1.9.0",
3435
],
3536
extras_require={
3637
"qa": [

0 commit comments

Comments
 (0)