Cant Register with same emails of different domain

[Manancode]

When Signin Up , The server logic implements an autoassigned username according to the email-id of the user
eg - If you sign up with johndae@gmail.com your username will be johndae . Also its a good practice since no two usernames cant be same .
Issue was if you try to sign up with two emails with different domains like johndae@gmail.com and johndae@yahoo.com , it throws an error which should not be a case . Since it will make two username to be same it throws an internal server error

[GURUPRASADSHARMA]

*solution

• create an checks for email with endWith() function and then generate the username by adding some unique key in the username for @gmail.com or @yahoo.com or any other
  *may this will help

[Pari100]

Hello Good Morning Sir,

I want to give my suggestion regarding this issue where users with same email name but different domains are failing to register and it throws an internal server error.

My Solution :

Instead of checking domains, we should directly check username uniqueness.

• While generating the username:
• Extract base name from email (example: johndae).
• Check in database if username already exists.
• If exists, then query all usernames starting with "johndae".
• Find the highest number suffix.
• Add incremented number to create new username.

Example :
If existing usernames are:

• johndae
• johndae1
• johndae2

Total users with same base name = 3
Then new username should be: johndae3

Problem in endsWith() Solution :

One solution given was to use endsWith() to check domains like @gmail.com, @yahoo.com and then add some unique key.

But there are hundreds of email domains, so checking each domain using endsWith() is not a good scalable solution. It adds extra condition checks and unnecessary logic. Also, domain name is not directly related to username uniqueness. So it increases complexity and computation.

[o1-spec]

Hi sir,

I investigated this issue in openwisp-wifi-login-pages to understand where the username is being generated.

From what I can see:

• In client/components/registration/registration.js, the frontend sends the payload with username: email.
• In server/controllers/registration-controller.js, this payload is proxied to registerUrl without any manipulation of the username.
• I could not find any logic in this repository that splits the email (e.g. email.split('@')[0]) or modifies the username before sending it to the backend.

Based on this, it appears that the transformation from johndae@gmail.com → johndae, and the resulting username collision, is likely happening in the backend API (possibly in openwisp-users or the main OpenWISP controller).

Could you please confirm whether this issue should instead be addressed in the backend repository? If so, which repository would be the correct place to track/fix it?

Thanks.

[nemesifier]

@o1-spec I think the issue is in openwisp-radius.

[o1-spec]

Thanks for the clarification.

I have opened an issue in openwisp-radius to track this properly:
openwisp/openwisp-radius#685

Since openwisp-wifi-login-pages sends username: email unchanged and proxies it to registerUrl, the username transformation and resulting collision appear to be handled server-side in openwisp-radius.

I will continue the investigation and proposed fix there.