flake8

Author: birdsarah

domain_utils/domain_utils.py

@@ -124,8 +124,10 @@ def get_stripped_url(url, scheme=False, drop_non_http=False, use_netloc=True):
     becomes ``my.domain.net/a/path/to/a/file.html``
 
     URL parsing is done using std lib
-    `urllib.parse.urlparse <https://docs.python.org/3.8/library/urllib.parse.html>`_.
-    Empty scheme e.g. ``my.domain.cloudfront.net`` are assumed to be http schemes.
+    `urllib.parse.urlparse
+    <https://docs.python.org/3.8/library/urllib.parse.html>`_.
+    Empty scheme e.g. ``my.domain.cloudfront.net``
+    are assumed to be http schemes.
 
     If a URL has a port but no scheme, urlparse determines the scheme to
     be the hostname and we do not handle this special case. In this case,
@@ -147,7 +149,7 @@ def get_stripped_url(url, scheme=False, drop_non_http=False, use_netloc=True):
         Default is ``False``.
     :type drop_non_http: bool, optional
     :param use_netloc: If ``True`` urlparse's netloc will be used.
-        If ``False`` urlparse's host will be returned. Using netloc means 
+        If ``False`` urlparse's host will be returned. Using netloc means
         that a port is included, for example, if it was in the path.
         Default is ``True``.
     :type use_netloc: bool, optional

tests/test_domain_utils.py

@@ -96,22 +96,22 @@ def test_get_stripped_url_returns_port_if_present_and_use_netloc_false():
 Currently don't support urls with a port but no scheme in the way we want.
 
 url = 'my.example.com:8080/path/to/webapp.htm?aced=1'
-ParseResult(scheme='my.example.com', netloc='', path='8080/path/to/webapp.htm',...
+ParseResult(scheme='my.example.com', netloc='', path='8080/path/to/webapp.htm',
 
 The following are two tests xfailed with expected behavior and one test
 that documents the actual behavior
 """
 
-@pytest.mark.xfail(reason="""
-urlparse does not have a good way to handle a url with a port but no scheme.""")
+port_no_schema_msg = """
+urlparse does not have a good way to handle a url with a port but no scheme."""
+@pytest.mark.xfail(reason=port_no_schema_msg)
 def test_get_stripped_with_port_when_no_scheme():
     url = 'my.example.com:8080/path/to/webapp.htm?aced=1'
     result = du.get_stripped_url(url)
     assert result == 'my.example.com:8080/path/to/webapp.htm'
 
 
-@pytest.mark.xfail(reason="""
-urlparse does not have a good way to handle a url with a port but no scheme.""")
+@pytest.mark.xfail(reason=port_no_schema_msg)
 def test_get_stripped_url_with_port_when_no_scheme_and_use_netloc_false():
     url = 'my.example.com:8080/path/to/webapp.htm?aced=1'
     result = du.get_stripped_url(url, use_netloc=False)