Skip to content

Commit 0cf69e0

Browse files
steffenmllrsergseven
authored andcommitted
Fix Nullpointer on empty auction context (prebid#3618)
1 parent f02d6a0 commit 0cf69e0

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

src/main/java/org/prebid/server/analytics/reporter/agma/AgmaAnalyticsReporter.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ public <T> Future<Void> processEvent(T event) {
116116
}
117117

118118
final AuctionContext auctionContext = contextAndType.getLeft();
119+
final String eventType = contextAndType.getRight();
120+
if (auctionContext == null) {
121+
return Future.succeededFuture();
122+
}
123+
119124
final BidRequest bidRequest = auctionContext.getBidRequest();
120125
final TimeoutContext timeoutContext = auctionContext.getTimeoutContext();
121126
final PrivacyContext privacyContext = auctionContext.getPrivacyContext();
@@ -134,7 +139,7 @@ public <T> Future<Void> processEvent(T event) {
134139
}
135140

136141
final AgmaEvent agmaEvent = AgmaEvent.builder()
137-
.eventType(contextAndType.getRight())
142+
.eventType(eventType)
138143
.accountCode(accountCode)
139144
.requestId(bidRequest.getId())
140145
.app(bidRequest.getApp())

src/test/java/org/prebid/server/analytics/reporter/agma/AgmaAnalyticsReporterTest.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,21 @@ public void setUp() {
109109
target = new AgmaAnalyticsReporter(properties, versionProvider, jacksonMapper, clock, httpClient, vertx);
110110
}
111111

112+
@Test
113+
public void processEventShouldNotSendAnythingWhenAuctionContextIsNull() {
114+
// given
115+
final AuctionEvent auctionEvent = AuctionEvent.builder()
116+
.auctionContext(null)
117+
.build();
118+
119+
// when
120+
final Future<Void> result = target.processEvent(auctionEvent);
121+
122+
// then
123+
verifyNoInteractions(httpClient);
124+
assertThat(result.succeeded()).isTrue();
125+
}
126+
112127
@Test
113128
public void processEventShouldSendEventWhenEventIsAuctionEvent() {
114129
// given

0 commit comments

Comments
 (0)