Skip to content

Commit a339ea7

Browse files
And1sSsergseven
authored andcommitted
Amp: update consented providers settings support (prebid#3590)
1 parent 02cec96 commit a339ea7

File tree

6 files changed

+18
-4
lines changed

6 files changed

+18
-4
lines changed

src/main/java/org/prebid/server/auction/requestfactory/AmpRequestFactory.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ private static User createUser(ConsentParam consentParam, String addtlConsent) {
274274

275275
final ExtUser extUser = consentedProvidersSettings != null
276276
? ExtUser.builder()
277+
.deprecatedConsentedProvidersSettings(consentedProvidersSettings)
277278
.consentedProvidersSettings(consentedProvidersSettings)
278279
.build()
279280
: null;

src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtUser.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,13 @@ public class ExtUser extends FlexibleExtension {
5555

5656
/**
5757
* Defines the contract for bidrequest.user.ext.ConsentedProvidersSettings
58+
* <p>
59+
* TODO: Remove after PBS 4.0
5860
*/
61+
@Deprecated(forRemoval = true)
5962
@JsonProperty("ConsentedProvidersSettings")
63+
ConsentedProvidersSettings deprecatedConsentedProvidersSettings;
64+
6065
ConsentedProvidersSettings consentedProvidersSettings;
6166

6267
@JsonIgnore

src/test/java/org/prebid/server/auction/requestfactory/AmpRequestFactoryTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1277,10 +1277,12 @@ public void shouldReturnBidRequestWithProvidersSettingsContainsAddtlConsentIfPar
12771277
final BidRequest result = target.fromRequest(routingContext, 0L).result().getBidRequest();
12781278

12791279
// then
1280+
final ConsentedProvidersSettings settings = ConsentedProvidersSettings.of("someConsent");
12801281
assertThat(result.getUser())
12811282
.isEqualTo(User.builder()
12821283
.ext(ExtUser.builder()
1283-
.consentedProvidersSettings(ConsentedProvidersSettings.of("someConsent"))
1284+
.deprecatedConsentedProvidersSettings(settings)
1285+
.consentedProvidersSettings(settings)
12841286
.build())
12851287
.build());
12861288
}

src/test/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidderTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public void makeHttpRequestsShouldUseProperEndpoints() {
116116
public void makeHttpRequestsShouldProperProcessConsentedProvidersSetting() {
117117
// given
118118
final ExtUser extUser = ExtUser.builder()
119-
.consentedProvidersSettings(ConsentedProvidersSettings.of("1~10.20.90"))
119+
.deprecatedConsentedProvidersSettings(ConsentedProvidersSettings.of("1~10.20.90"))
120120
.build();
121121

122122
final BidRequest bidRequest = givenBidRequest(bidRequestBuilder -> bidRequestBuilder
@@ -145,7 +145,7 @@ public void makeHttpRequestsShouldProperProcessConsentedProvidersSetting() {
145145
public void makeHttpRequestsShouldProperProcessConsentedProvidersSettingWithMultipleTilda() {
146146
// given
147147
final ExtUser extUser = ExtUser.builder()
148-
.consentedProvidersSettings(ConsentedProvidersSettings.of("1~10.20.90~anything"))
148+
.deprecatedConsentedProvidersSettings(ConsentedProvidersSettings.of("1~10.20.90~anything"))
149149
.build();
150150

151151
final BidRequest bidRequest = givenBidRequest(bidRequestBuilder -> bidRequestBuilder
@@ -174,7 +174,7 @@ public void makeHttpRequestsShouldProperProcessConsentedProvidersSettingWithMult
174174
public void makeHttpRequestsShouldReturnUserExtIfConsentedProvidersIsNotProvided() {
175175
// given
176176
final ExtUser extUser = ExtUser.builder()
177-
.consentedProvidersSettings(ConsentedProvidersSettings.of(null))
177+
.deprecatedConsentedProvidersSettings(ConsentedProvidersSettings.of(null))
178178
.build();
179179

180180
final BidRequest bidRequest = givenBidRequest(bidRequestBuilder ->

src/test/resources/org/prebid/server/it/amp/test-generic-bid-request.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@
5151
"ext": {
5252
"ConsentedProvidersSettings": {
5353
"consented_providers": "someConsent"
54+
},
55+
"consented_providers_settings": {
56+
"consented_providers": "someConsent"
5457
}
5558
}
5659
},

src/test/resources/org/prebid/server/it/amp/test-genericAlias-bid-request.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,9 @@
4949
"ext": {
5050
"ConsentedProvidersSettings": {
5151
"consented_providers": "someConsent"
52+
},
53+
"consented_providers_settings": {
54+
"consented_providers": "someConsent"
5255
}
5356
}
5457
},

0 commit comments

Comments
 (0)