Integrate LLVM at llvm/llvm-project@0230d63b4a8b (#2752)

Other than the usual integration, this PR also addresses the followings:

1. Disables certain build and tests for
#2751.

In stablehlo/conversions/tosa/transforms/CMakeLists.txt, just commenting
the problematic files is not enough because

```
 LLVM's build system enforces that all source files are added to a build target
```

Hence we added add `PARTIAL_SOURCES_INTENDED` to the target
specification, though it is discouraged.

1. Fixes `build_tools/integrate/llvm_bump_revision.sh` to account for
unset value of `$1` as enforced by `set -o nounset`

Author: sdasgup3

BUILD.bazel

@@ -1578,8 +1578,9 @@ cc_library(
     srcs = [
         "stablehlo/conversions/tosa/transforms/StablehloLegalizeToTosa.cpp",
         "stablehlo/conversions/tosa/transforms/StablehloPrepareForTosa.cpp",
-        "stablehlo/conversions/tosa/transforms/StablehloQuantLegalizeToTosaRescale.cpp",
-        "stablehlo/conversions/tosa/transforms/TosaRescaleLegalizeToStablehlo.cpp",
+        # TODO: un-comment the following once #2751 is fixed
+        # "stablehlo/conversions/tosa/transforms/StablehloQuantLegalizeToTosaRescale.cpp",
+        # "stablehlo/conversions/tosa/transforms/TosaRescaleLegalizeToStablehlo.cpp",
     ],
     hdrs = [
         "stablehlo/conversions/tosa/transforms/Passes.h",

WORKSPACE.bazel

@@ -17,9 +17,9 @@ workspace(name = "stablehlo")
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-LLVM_COMMIT = "f01e760c08365426de95f02dc2c2dc670eb47352"
+LLVM_COMMIT = "0230d63b4a8b9f420b0aaac373891df1199715a8"
 
-LLVM_SHA256 = "abd6f774f8580a9694dc847bd9ce624a4f3e8784543331a6255e2cc6967a6e41"
+LLVM_SHA256 = "27641dbb2ee0fecb6f084a4300b0c27ac692c2d1214fad236dc5e19dd7962693"
 
 http_archive(
     name = "llvm-raw",

build_tools/integrate/llvm_bump_revision.sh

@@ -22,6 +22,7 @@ usage_and_exit() {
 SCRIPT_DIR="$(dirname "$(realpath "$0")")"
 GH_ACTIONS="$SCRIPT_DIR/../github_actions"
 REPO_ROOT="$SCRIPT_DIR/../.."
+PATCH_OPTION="${1:-}"
 
 # Update build files
 bump_to_xla_llvm_version() {
@@ -54,8 +55,8 @@ set -o nounset  # Using uninitialized variables raises error and exits
 set -o pipefail # Ensures the script detects errors in any part of a pipeline.
 
 APPLY_PATCH=1
-if [[ -n "$1" ]]; then
-  if [[ "$1" == "-nopatch" ]]; then
+if [[ -n "$PATCH_OPTION" ]]; then
+  if [[ "$PATCH_OPTION" == "-nopatch" ]]; then
     APPLY_PATCH=0
     echo "Skipping patch apply."
   else

build_tools/llvm_version.txt

@@ -1 +1 @@
-f01e760c08365426de95f02dc2c2dc670eb47352
+0230d63b4a8b9f420b0aaac373891df1199715a8

docs/generated/stablehlo_tosa_passes.md

@@ -10,17 +10,3 @@ _Prepare StableHLO for legalization to TOSA_
 
 This pass adds rewriters to make StableHLO ops more compatible with TOSA ops.
 Currently simplifies stablehlo.dot_general into stablehlo.dot for easier lowering.
-
-### `-stablehlo-quant-legalize-to-tosa-rescale`
-
-_Legalize StableHLO Quantized operations to TOSA rescale operations_
-
-This pass rewrites StableHLO quantized operations to integer operations
-by inserting TOSA rescale operations at the inputs and outputs of the
-integer operations.
-
-### `-tosa-rescale-legalize-to-stablehlo`
-
-_Legalize TOSA rescales to StableHlo primitive math operations_
-
-This pass rewrites TOSA rescale operations to StableHLO primitive math operations.

stablehlo/conversions/tosa/tests/BUILD.bazel

@@ -55,7 +55,18 @@ RUNFILES_DIR = LITE_CFG_PY.parents[4].absolute().as_posix()''',
         tags = ["stablehlo_tosa_tests"],
         deps = ["@rules_python//python/runfiles"],
     )
-    for src in glob(["**/*.mlir"])
+    # TODO: remove the following excludes once #2751 is fixed.
+    for src in glob(
+        ["**/*.mlir"],
+        exclude = [
+            "legalize_quant_ops_to_tosa_rescale.mlir",
+            "legalize_tosa_rescale_to_stablehlo.mlir",
+            "rescale_interpreter.mlir",
+            "binary.mlir",
+            "nullary.mlir",
+            "unary.mlir",
+        ],
+    )
 ]
 
 test_suite(

stablehlo/conversions/tosa/tests/lit.cfg.py

@@ -25,6 +25,8 @@
 config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
 config.suffixes = ['.mlir']
 config.test_source_root = os.path.dirname(__file__)
+# TODO: remove the following once #2751 is fixed.
+config.excludes = ['legalize_quant_ops_to_tosa_rescale.mlir', 'legalize_tosa_rescale_to_stablehlo.mlir', 'rescale_interpreter.mlir', 'binary.mlir', 'nullary.mlir', 'unary.mlir']
 
 # Disallow reusing variables across CHECK-LABEL matches.
 # A variable can eschew this (be made "global") by prefixing its name with $.

stablehlo/conversions/tosa/transforms/CMakeLists.txt

@@ -25,9 +25,11 @@ add_mlir_pdll_library(StablehloTOSAPDLLPatternsIncGen
 add_mlir_library(StablehloTOSATransforms
   StablehloLegalizeToTosa.cpp
   StablehloPrepareForTosa.cpp
-  StablehloQuantLegalizeToTosaRescale.cpp
-  TosaRescaleLegalizeToStablehlo.cpp
+  # TODO: un-comment the following once #2751 is fixed.
+  # StablehloQuantLegalizeToTosaRescale.cpp
+  # TosaRescaleLegalizeToStablehlo.cpp
 
+  PARTIAL_SOURCES_INTENDED
   DEPENDS
   StablehloTOSATransformsPassIncGen
   StablehloTOSAPDLLPatternsIncGen

stablehlo/conversions/tosa/transforms/Passes.td

@@ -33,24 +33,25 @@ def StablehloPrepareForTosaPass : Pass<"stablehlo-prepare-for-tosa", "mlir::func
   let dependentDialects = ["::mlir::tosa::TosaDialect"];
 }
 
-def StablehloQuantLegalizeToTosaRescalePass : Pass<"stablehlo-quant-legalize-to-tosa-rescale", "mlir::func::FuncOp"> {
-  let summary = "Legalize StableHLO Quantized operations to TOSA rescale operations";
-  let description = [{
-    This pass rewrites StableHLO quantized operations to integer operations
-    by inserting TOSA rescale operations at the inputs and outputs of the
-    integer operations.
-  }];
-  let dependentDialects = [
-    "::mlir::tosa::TosaDialect",
-  ];
-}
-
-def TosaRescaleLegalizeToStablehloPass : Pass<"tosa-rescale-legalize-to-stablehlo", "mlir::func::FuncOp"> {
-  let summary = "Legalize TOSA rescales to StableHlo primitive math operations";
-  let description = [{
-    This pass rewrites TOSA rescale operations to StableHLO primitive math operations.
-  }];
-  let dependentDialects = [
-    "::mlir::stablehlo::StablehloDialect"
-  ];
-}
+// TODO: un-comment the following once #2751 is fixed.
+// def StablehloQuantLegalizeToTosaRescalePass : Pass<"stablehlo-quant-legalize-to-tosa-rescale", "mlir::func::FuncOp"> {
+//   let summary = "Legalize StableHLO Quantized operations to TOSA rescale operations";
+//   let description = [{
+//     This pass rewrites StableHLO quantized operations to integer operations
+//     by inserting TOSA rescale operations at the inputs and outputs of the
+//     integer operations.
+//   }];
+//   let dependentDialects = [
+//     "::mlir::tosa::TosaDialect",
+//   ];
+// }
+//
+// def TosaRescaleLegalizeToStablehloPass : Pass<"tosa-rescale-legalize-to-stablehlo", "mlir::func::FuncOp"> {
+//   let summary = "Legalize TOSA rescales to StableHlo primitive math operations";
+//   let description = [{
+//     This pass rewrites TOSA rescale operations to StableHLO primitive math operations.
+//   }];
+//   let dependentDialects = [
+//     "::mlir::stablehlo::StablehloDialect"
+//   ];
+// }