Fix alias analysis compiler errors

Author: acollins3

include/triton/Analysis/Alias.h

@@ -85,9 +85,10 @@ class SharedMemoryAliasAnalysis
   }
 
   /// Computes if the alloc set of the results are changed.
-  LogicalResult visitOperation(
-      Operation *op, ArrayRef<const dataflow::Lattice<AliasInfo> *> operands,
-      ArrayRef<dataflow::Lattice<AliasInfo> *> results) override;
+  void
+  visitOperation(Operation *op,
+                 ArrayRef<const dataflow::Lattice<AliasInfo> *> operands,
+                 ArrayRef<dataflow::Lattice<AliasInfo> *> results) override;
 };
 
 } // namespace mlir

lib/Analysis/Alias.cpp

@@ -21,7 +21,7 @@ AliasInfo AliasInfo::join(const AliasInfo &lhs, const AliasInfo &rhs) {
   return ret;
 }
 
-LogicalResult SharedMemoryAliasAnalysis::visitOperation(
+void SharedMemoryAliasAnalysis::visitOperation(
     Operation *op, ArrayRef<const dataflow::Lattice<AliasInfo> *> operands,
     ArrayRef<dataflow::Lattice<AliasInfo> *> results) {
   AliasInfo aliasInfo;
@@ -31,7 +31,7 @@ LogicalResult SharedMemoryAliasAnalysis::visitOperation(
   if (auto memdescTy = dyn_cast<triton::MemDescType>(result.getType())) {
     if (!isa_and_nonnull<triton::gpu::SharedMemorySpaceAttr>(
             memdescTy.getMemorySpace()))
-      return mlir::success();
+      return;
   }
 
   // Only LocalAllocOp creates a new buffer.
@@ -50,12 +50,12 @@ LogicalResult SharedMemoryAliasAnalysis::visitOperation(
 
   if (pessimistic) {
     setAllToEntryStates(results);
-    return mlir::success();
+    return;
   }
   // Join all lattice elements
   for (auto *result : results)
     propagateIfChanged(result, result->join(aliasInfo));
-  return mlir::success();
+  return;
 }
 
 AliasResult SharedMemoryAliasAnalysis::alias(Value lhs, Value rhs) {

lib/Analysis/AxisInfo.cpp

@@ -195,9 +195,9 @@ class AxisInfoAnalysis : public dataflow::SparseForwardDataFlowAnalysis<
       dataflow::Lattice<AxisInfo>>::getLatticeElement;
   using FuncAxisInfoMapT = DenseMap<FunctionOpInterface, AxisInfo>;
 
-  LogicalResult visitOperation(
-      Operation *op, ArrayRef<const dataflow::Lattice<AxisInfo> *> operands,
-      ArrayRef<dataflow::Lattice<AxisInfo> *> results) override;
+  void visitOperation(Operation *op,
+                      ArrayRef<const dataflow::Lattice<AxisInfo> *> operands,
+                      ArrayRef<dataflow::Lattice<AxisInfo> *> results) override;
   void
   visitForOpInductionVar(scf::ForOp op,
                          ArrayRef<dataflow::Lattice<AxisInfo> *> argLattices);
@@ -1039,7 +1039,7 @@ AxisInfoAnalysis::AxisInfoAnalysis(DataFlowSolver &solver)
   visitors.append<LoadOpAxisInfoVisitor>();
 }
 
-LogicalResult AxisInfoAnalysis::visitOperation(
+void AxisInfoAnalysis::visitOperation(
     Operation *op, ArrayRef<const dataflow::Lattice<AxisInfo> *> operands,
     ArrayRef<dataflow::Lattice<AxisInfo> *> results) {
   // TODO: For sure not the right way to do this
@@ -1050,7 +1050,7 @@ LogicalResult AxisInfoAnalysis::visitOperation(
   AxisInfo curr = visitors.apply(op, operands);
   if (curr.getRank() == 0) {
     setAllToEntryStates(results);
-    return mlir::success();
+    return;
   }
   // override with hint
   auto newContiguity = curr.getContiguity();
@@ -1073,7 +1073,7 @@ LogicalResult AxisInfoAnalysis::visitOperation(
   // join all lattice elements
   for (auto *result : results)
     propagateIfChanged(result, result->join(curr));
-  return mlir::success();
+  return;
 }
 
 void AxisInfoAnalysis::visitForOpInductionVar(