Skip to content

Commit 8aedb5e

Browse files
wkparkchsigg
authored andcommitted
[BUILD] enable win32 llvm build (triton-lang#4941)
from triton-lang#2757 * fix deprecation warning * use bash shell to fix `az storage ...` console error. * `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency - `"ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it"`. the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported. p.s.: and I'd like to thank all triton developers for their hard work!
1 parent 9a49f89 commit 8aedb5e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/llvm-build.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ jobs:
3131
- {runner: 'AlmaLinux 8', runs_on: ['self-hosted', 'CPU'], target-os: 'almalinux', arch: 'x64'}
3232
- {runner: 'MacOS X64', runs_on: 'macos-12', target-os: 'macos', arch: 'x64'}
3333
- {runner: 'MacOS ARM64', runs_on: 'macos-12', target-os: 'macos', arch: 'arm64'}
34-
# TODO(#2805): add back once the workflow works and runs in comparable time to the other ones
35-
# - {runner: 'Windows Latest', runs_on: 'windows-latest', target-os: 'windows', arch: 'x64'}
34+
- {runner: 'Windows Latest', runs_on: 'windows-latest', target-os: 'windows', arch: 'x64'}
3635

3736
steps:
3837

@@ -126,7 +125,8 @@ jobs:
126125
-DLLVM_BUILD_TOOLS=ON
127126
-DLLVM_ENABLE_ASSERTIONS=ON
128127
-DMLIR_ENABLE_BINDINGS_PYTHON=ON
129-
-DLLVM_ENABLE_PROJECTS="clang;mlir"
128+
-DLLVM_ENABLE_PROJECTS="mlir;llvm"
129+
-DLLVM_ENABLE_DIA_SDK=OFF
130130
-DLLVM_INSTALL_UTILS=ON
131131
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU"
132132
-DLLVM_ENABLE_TERMINFO=OFF
@@ -273,6 +273,7 @@ jobs:
273273

274274
- name: Upload LLVM Artifacts to Azure
275275
if: ${{ (github.repository == 'triton-lang/triton') }}
276+
shell: bash -el {0}
276277
run: |
277278
az storage blob upload --account-name oaitriton --auth-mode login --container-name public --file "${{ env.llvm_install_dir }}.tar.gz" --name "llvm-builds/${{ env.llvm_install_dir }}.tar.gz" --overwrite
278279

0 commit comments

Comments
 (0)