Skip to content

Commit 4492860

Browse files
nvgrwGoogle-ML-Automation
authored andcommitted
Tag PjRt migration candidates explicitly. (BUILD changes)
This change adds a new tag "pjrt_migration_candidate" to all test targets that depend on HloTestBase, ClientLibraryTestBase, and HloRunnerTpuSystem. This change also adds a new `use_legacy_runtime` kwarg to `xla_test`, which acts as a replacement for "test_migrated_to_hlo_runner_pjrt". During a brief transition phase, we will leave all "test_migrated_to_hlo_runner_pjrt" tags in place so that we can identify any tests that have the `use_legacy_runtime` set to an incorrect value. "pjrt_migration_candidate" and "test_migrated_to_hlo_runner_pjrt" are mutually exclusive. "pjrt_migration_candidate" should not appear on any tests using the new runtime. Unlike "test_migrated_to_hlo_runner_pjrt", which primarily tags `xla_test` targets, "pjrt_migration_candidate" intends to tag all outstanding migration candidates to obtain an accurate picture of migration progress. If a test cannot or should not be migrated, it can be excluded from any analysis just by removing the tag. PiperOrigin-RevId: 853290979
1 parent b74b7d0 commit 4492860

File tree

1 file changed

+26
-0
lines changed
  • xla/service/gpu/transforms

1 file changed

+26
-0
lines changed

xla/service/gpu/transforms/BUILD

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ cc_library(
171171
xla_cc_test(
172172
name = "async_wrapper_test",
173173
srcs = ["async_wrapper_test.cc"],
174+
tags = ["pjrt_migration_candidate"],
174175
deps = [
175176
":async_wrapper",
176177
"//xla:literal",
@@ -327,6 +328,7 @@ cc_library(
327328
xla_cc_test(
328329
name = "block_scaling_rewriter_test",
329330
srcs = ["block_scaling_rewriter_test.cc"],
331+
tags = ["pjrt_migration_candidate"],
330332
deps = [
331333
":block_scaling_rewriter",
332334
"//xla/hlo/ir:hlo",
@@ -450,6 +452,7 @@ cc_library(
450452
xla_cc_test(
451453
name = "conv_rewriter_test",
452454
srcs = ["conv_rewriter_test.cc"],
455+
tags = ["pjrt_migration_candidate"],
453456
deps = [
454457
":conv_rewriter",
455458
"//xla:array4d",
@@ -649,6 +652,8 @@ xla_test(
649652
"amdgpu_any",
650653
] + if_oss(["nvgpu_any"]),
651654
shard_count = 10,
655+
tags = ["pjrt_migration_candidate"],
656+
use_legacy_runtime = True,
652657
deps = [
653658
":conv_rewriter",
654659
":cudnn_fused_conv_rewriter",
@@ -779,6 +784,8 @@ xla_test(
779784
srcs = ["cudnn_norm_rewriter_test.cc"],
780785
backends = ["gpu"],
781786
local_defines = if_cuda_is_configured(["GOOGLE_CUDA=1"]),
787+
tags = ["pjrt_migration_candidate"],
788+
use_legacy_runtime = True,
782789
deps = [
783790
":cudnn_norm_rewriter",
784791
"//xla:error_spec",
@@ -1003,6 +1010,8 @@ xla_test(
10031010
name = "dot_dimension_sorter_test",
10041011
srcs = ["dot_dimension_sorter_test.cc"],
10051012
backends = ["gpu"],
1013+
tags = ["pjrt_migration_candidate"],
1014+
use_legacy_runtime = True,
10061015
deps = [
10071016
":dot_dimension_sorter",
10081017
"//xla:error_spec",
@@ -1073,6 +1082,8 @@ xla_test(
10731082
"b200",
10741083
"amdgpu_any",
10751084
],
1085+
tags = ["pjrt_migration_candidate"],
1086+
use_legacy_runtime = True,
10761087
deps = if_gpu_is_configured(
10771088
[
10781089
":dot_operand_converter",
@@ -1380,6 +1391,8 @@ xla_test(
13801391
name = "gemm_broadcast_folding_rewriter_test",
13811392
srcs = ["gemm_broadcast_folding_rewriter_test.cc"],
13821393
backends = ["gpu"],
1394+
tags = ["pjrt_migration_candidate"],
1395+
use_legacy_runtime = True,
13831396
deps = [
13841397
":gemm_broadcast_folding_rewriter",
13851398
":gemm_rewriter",
@@ -1422,6 +1435,8 @@ xla_test(
14221435
name = "gemm_workspace_rewriter_test",
14231436
srcs = ["gemm_workspace_rewriter_test.cc"],
14241437
backends = ["gpu"],
1438+
tags = ["pjrt_migration_candidate"],
1439+
use_legacy_runtime = True,
14251440
deps = [
14261441
":gemm_workspace_rewriter",
14271442
"//xla/hlo/ir:hlo",
@@ -1593,6 +1608,8 @@ xla_test(
15931608
name = "gemm_rewriter_test",
15941609
srcs = ["gemm_rewriter_test.cc"],
15951610
backends = ["gpu"],
1611+
tags = ["pjrt_migration_candidate"],
1612+
use_legacy_runtime = True,
15961613
deps = [
15971614
":gemm_rewriter",
15981615
":gemm_rewriter_test_lib",
@@ -1625,6 +1642,8 @@ xla_test(
16251642
name = "cublas_gemm_rewriter_test",
16261643
srcs = ["cublas_gemm_rewriter_test.cc"],
16271644
backends = ["gpu"],
1645+
tags = ["pjrt_migration_candidate"],
1646+
use_legacy_runtime = True,
16281647
deps = [
16291648
":gemm_rewriter",
16301649
":gemm_rewriter_test_lib",
@@ -1654,6 +1673,8 @@ xla_test(
16541673
srcs = ["gemm_rewriter_fp8_test.cc"],
16551674
backends = ["gpu"],
16561675
shard_count = 5,
1676+
tags = ["pjrt_migration_candidate"],
1677+
use_legacy_runtime = True,
16571678
deps = [
16581679
":gemm_rewriter",
16591680
":gemm_rewriter_test_lib",
@@ -1755,6 +1776,7 @@ cc_library(
17551776
xla_cc_test(
17561777
name = "layout_assignment_test",
17571778
srcs = ["layout_assignment_test.cc"],
1779+
tags = ["pjrt_migration_candidate"],
17581780
deps = [
17591781
":layout_assignment",
17601782
"//xla:shape_layout",
@@ -2858,6 +2880,8 @@ xla_test(
28582880
name = "topk_specializer_test",
28592881
srcs = ["topk_specializer_test.cc"],
28602882
backends = ["gpu"],
2883+
tags = ["pjrt_migration_candidate"],
2884+
use_legacy_runtime = True,
28612885
deps = [
28622886
":topk_specializer",
28632887
"//xla:shape_util",
@@ -2900,6 +2924,7 @@ cc_library(
29002924
xla_cc_test(
29012925
name = "topk_splitter_test",
29022926
srcs = ["topk_splitter_test.cc"],
2927+
tags = ["pjrt_migration_candidate"],
29032928
deps = [
29042929
":topk_splitter",
29052930
"//xla/hlo/ir:hlo",
@@ -3473,6 +3498,7 @@ xla_cc_test(
34733498
xla_cc_test(
34743499
name = "scaled_dot_rewriter_test",
34753500
srcs = ["scaled_dot_rewriter_test.cc"],
3501+
tags = ["pjrt_migration_candidate"],
34763502
deps = [
34773503
":scaled_dot_rewriter",
34783504
"//xla:error_spec",

0 commit comments

Comments
 (0)