Skip to content

Commit 4616f1a

Browse files
nvgrwGoogle-ML-Automation
authored andcommitted
Tag PjRt migration candidates explicitly. (BUILD changes)
This change adds a new tag "pjrt_migration_candidate" to all test targets that depend on HloTestBase, ClientLibraryTestBase, and HloRunnerTpuSystem. This change also adds a new `use_legacy_runtime` kwarg to `xla_test`, which acts as a replacement for "test_migrated_to_hlo_runner_pjrt". During a brief transition phase, we will leave all "test_migrated_to_hlo_runner_pjrt" tags in place so that we can identify any tests that have the `use_legacy_runtime` set to an incorrect value. "pjrt_migration_candidate" and "test_migrated_to_hlo_runner_pjrt" are mutually exclusive. "pjrt_migration_candidate" should not appear on any tests using the new runtime. Unlike "test_migrated_to_hlo_runner_pjrt", which primarily tags `xla_test` targets, "pjrt_migration_candidate" intends to tag all outstanding migration candidates to obtain an accurate picture of migration progress. If a test cannot or should not be migrated, it can be excluded from any analysis just by removing the tag. PiperOrigin-RevId: 852941506
1 parent b1ee739 commit 4616f1a

File tree

1 file changed

+10
-1
lines changed
  • xla/service/gpu/autotuning

1 file changed

+10
-1
lines changed

xla/service/gpu/autotuning/BUILD

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,9 @@ xla_test(
246246
tags = [
247247
"cuda-only",
248248
"no_mac",
249+
"pjrt_migration_candidate",
249250
],
251+
use_legacy_runtime = True,
250252
deps = [
251253
":autotune_cache_key",
252254
":autotuner_util",
@@ -542,6 +544,8 @@ xla_test(
542544
name = "redzone_buffers_test",
543545
srcs = ["redzone_buffers_test.cc"],
544546
backends = ["gpu"],
547+
tags = ["pjrt_migration_candidate"],
548+
use_legacy_runtime = True,
545549
deps = [
546550
":redzone_buffers",
547551
"//xla:shape_util",
@@ -630,7 +634,9 @@ xla_test(
630634
"cuda-only",
631635
"noasan",
632636
"nomsan",
637+
"pjrt_migration_candidate",
633638
],
639+
use_legacy_runtime = True,
634640
deps = [
635641
":autotuner_util",
636642
":conv_algorithm_picker",
@@ -674,7 +680,10 @@ xla_cc_test(
674680
name = "autotuner_util_test",
675681
srcs = ["autotuner_util_test.cc"],
676682
data = ["//xla/backends/gpu/target_config:all_gpu_specs"],
677-
tags = ["gpu"],
683+
tags = [
684+
"gpu",
685+
"pjrt_migration_candidate",
686+
],
678687
deps = [
679688
":autotune_cache_key",
680689
":autotuner_status_key",

0 commit comments

Comments
 (0)