Skip to content

Commit 81b49f3

Browse files
[XLA] Re-populate source_file, source_line, source_end_line, source_column, source_end_column to enable correct source code tracing in xprof.
PiperOrigin-RevId: 853006348
1 parent 8589766 commit 81b49f3

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

xla/hlo/translate/mhlo_to_hlo/location_exporter.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@ xla::OpMetadata CreateOpMetadataFromLocation(
143143
auto result = frame_index_builder->AddCallStackAndGetFirstFrameId(loc);
144144
if (result.last_frame_id != mlir::StackFrameIndexBuilder::kInvalidIndex) {
145145
metadata.set_stack_frame_id(result.last_frame_id);
146+
metadata.set_source_file(result.last_frame_file);
147+
metadata.set_source_line(result.last_frame_line);
148+
metadata.set_source_end_line(result.last_frame_end_line);
149+
metadata.set_source_column(result.last_frame_column);
150+
metadata.set_source_end_column(result.last_frame_end_column);
146151
return metadata;
147152
}
148153
}

xla/hlo/translate/mhlo_to_hlo/tests/location_to_op_metadata.mlir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func.func @main(%arg0: !mhlo.token) -> !mhlo.token {
6262
}
6363

6464
// CHECK: after-all
65-
// CHECK-SAME: metadata={op_name="name(anothername)" stack_frame_id=1}
65+
// CHECK-SAME: metadata={op_name="name(anothername)" source_file="file_name" source_line=2 source_end_line=2 source_column=8 source_end_column=8 stack_frame_id=1}
6666

6767
// -----
6868

xla/hlo/translate/mhlo_to_hlo/tests/location_to_stacktrace.mlir

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,12 @@ module @main attributes {mhlo.cross_program_prefetches = [], mhlo.is_dynamic = f
3333
// CHECK-NEXT: }
3434
// CHECK-NEXT: metadata {
3535
// CHECK-NEXT: op_name: "name(anothername)"
36+
// CHECK-NEXT: source_file: "file_name"
37+
// CHECK-NEXT: source_line: 2
3638
// CHECK-NEXT: stack_frame_id: 1
39+
// CHECK-NEXT: source_end_line: 2
40+
// CHECK-NEXT: source_column: 8
41+
// CHECK-NEXT: source_end_column: 8
3742
// CHECK-NEXT: }
3843

3944
// CHECK: stack_frame_index {
@@ -74,7 +79,12 @@ module @main attributes {mhlo.cross_program_prefetches = [], mhlo.is_dynamic = f
7479
// CHECK-NEXT: metadata {
7580
// CHECK-NEXT: op_type: "atype"
7681
// CHECK-NEXT: op_name: "name(anothername)"
82+
// CHECK-NEXT: source_file: "file_name_2"
83+
// CHECK-NEXT: source_line: 3
7784
// CHECK-NEXT: stack_frame_id: 2
85+
// CHECK-NEXT: source_end_line: 3
86+
// CHECK-NEXT: source_column: 4
87+
// CHECK-NEXT: source_end_column: 4
7888
// CHECK-NEXT: }
7989

8090
// CHECK: stack_frame_index {

0 commit comments

Comments
 (0)