[XLA:GPU] Fix usages of deprecated tsl::errors::AlreadyExists in xla

This change replaces usages of tsl::errors::AlreadyExists with absl::AlreadyExistsError,
wrapping arguments in absl::StrCat where necessary. This addresses deprecation
warnings and moves towards standard Abseil error handling.

Changes:
- Replaced errors::AlreadyExists with absl::AlreadyExistsError.
- Used absl::StrCat to construct error messages where necessary.
PiperOrigin-RevId: 837128775

Author: loislo

xla/tsl/framework/device_id_manager.cc

@@ -55,16 +55,17 @@ class TfToPlatformDeviceIdMap {
           {tf_device_id.value(), platform_device_id.value()});
     }
     if (!result.second && platform_device_id.value() != result.first->second) {
-      return errors::AlreadyExists(
-          "TensorFlow device (", type, ":", tf_device_id.value(),
+      return absl::AlreadyExistsError(absl::StrCat(
+          "TensorFlow device (", type.type_string(), ":", tf_device_id.value(),
           ") is being mapped to multiple devices (", platform_device_id.value(),
           " now, and ", result.first->second,
           " previously), which is not supported. "
           "This may be the result of providing different ",
-          type, " configurations (ConfigProto.gpu_options, for example ",
+          type.type_string(),
+          " configurations (ConfigProto.gpu_options, for example ",
           "different visible_device_list) when creating multiple Sessions in ",
           "the same process. This is not currently supported, see ",
-          "https://github.com/tensorflow/tensorflow/issues/19083");
+          "https://github.com/tensorflow/tensorflow/issues/19083"));
     }
     return absl::OkStatus();
   }

xla/tsl/platform/cloud/BUILD

@@ -130,10 +130,13 @@ cc_library(
         "//xla/tsl/platform:status",
         "//xla/tsl/platform:types",
         "@com_google_absl//absl/base:core_headers",
+        "@com_google_absl//absl/log",
+        "@com_google_absl//absl/log:check",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/synchronization",
         "@com_google_absl//absl/time",
+        "@com_google_absl//absl/types:span",
         "@jsoncpp_git//:jsoncpp",
         "@tsl//tsl/platform:numbers",
         "@tsl//tsl/platform:path",
@@ -176,10 +179,13 @@ cc_library(
         "//xla/tsl/platform:status",
         "//xla/tsl/platform:types",
         "@com_google_absl//absl/base:core_headers",
+        "@com_google_absl//absl/log",
+        "@com_google_absl//absl/log:check",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/synchronization",
         "@com_google_absl//absl/time",
+        "@com_google_absl//absl/types:span",
         "@jsoncpp_git//:jsoncpp",
         "@tsl//tsl/platform:numbers",
         "@tsl//tsl/platform:path",

xla/tsl/platform/cloud/gcs_file_system.cc

@@ -17,13 +17,40 @@ limitations under the License.
 
 #include <stdio.h>
 
+#include <cstdint>
+#include <iosfwd>
+#include <limits>
 #include <memory>
+#include <set>
+#include <unordered_set>
 
+#include "absl/base/attributes.h"
+#include "absl/log/check.h"
+#include "absl/log/log.h"
 #include "absl/status/status.h"
+#include "absl/strings/ascii.h"
+#include "absl/strings/match.h"
+#include "absl/strings/numbers.h"
 #include "absl/strings/str_cat.h"
+#include "absl/strings/str_join.h"
+#include "absl/strings/str_split.h"
+#include "absl/strings/string_view.h"
+#include "absl/strings/strip.h"
 #include "absl/synchronization/mutex.h"
 #include "absl/time/clock.h"
 #include "absl/time/time.h"
+#include "absl/types/span.h"
+#include "xla/tsl/platform/cloud/auth_provider.h"
+#include "xla/tsl/platform/cloud/compute_engine_metadata_client.h"
+#include "xla/tsl/platform/cloud/compute_engine_zone_provider.h"
+#include "xla/tsl/platform/cloud/expiring_lru_cache.h"
+#include "xla/tsl/platform/cloud/gcs_dns_cache.h"
+#include "xla/tsl/platform/cloud/gcs_throttle.h"
+#include "xla/tsl/platform/cloud/http_request.h"
+#include "xla/tsl/platform/cloud/zone_provider.h"
+#include "xla/tsl/platform/file_system.h"
+#include "xla/tsl/platform/status.h"
+#include "xla/tsl/platform/types.h"
 #include "tsl/platform/retrying_file_system.h"
 
 #ifndef _WIN32
@@ -1986,7 +2013,7 @@ absl::Status GcsFileSystem::CreateDir(const string& dirname,
   if (FileExists(dirname_with_slash, token).ok()) {
     // Use the original name for a correct error here.
     VLOG(3) << "CreateDir: directory already exists, not uploading " << dirname;
-    return errors::AlreadyExists(dirname);
+    return absl::AlreadyExistsError(dirname);
   }
 
   std::unique_ptr<HttpRequest> request;

xla/tsl/platform/cloud/gcs_file_system_test.cc

@@ -3622,11 +3622,11 @@ TEST(GcsFileSystemTest, CreateDir_Folder) {
   TF_EXPECT_OK(fs.CreateDir("gs://bucket/subpath", nullptr));
   // Check that when GCS returns the object already exists return that the
   // directory already exists.
-  EXPECT_EQ(errors::AlreadyExists("gs://bucket/subpath"),
+  EXPECT_EQ(absl::AlreadyExistsError("gs://bucket/subpath"),
             fs.CreateDir("gs://bucket/subpath", nullptr));
   // Check that when GCS returns the object already has a version (failed
   // precondition) return directory already exists.
-  EXPECT_EQ(errors::AlreadyExists("gs://bucket/subpath"),
+  EXPECT_EQ(absl::AlreadyExistsError("gs://bucket/subpath"),
             fs.CreateDir("gs://bucket/subpath", nullptr));
 }
 

xla/tsl/platform/default/BUILD

@@ -164,12 +164,15 @@ cc_library(
         "@com_google_absl//absl/base:core_headers",
         "@com_google_absl//absl/base:nullability",
         "@com_google_absl//absl/functional:any_invocable",
+        "@com_google_absl//absl/log:check",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:cord",
         "@com_google_absl//absl/strings:str_format",
         "@com_google_absl//absl/synchronization",
         "@com_google_absl//absl/types:span",
+        "@com_google_protobuf//:protobuf",
+        "@com_google_protobuf//:protobuf_lite",
         "@eigen_archive//:eigen3",
         "@tsl//tsl/platform",
         "@tsl//tsl/platform:blocking_counter",
@@ -185,7 +188,6 @@ cc_library(
         "@tsl//tsl/platform:str_util",
         "@tsl//tsl/platform:strcat",
         "@tsl//tsl/platform:stringpiece",
-        "@tsl//tsl/platform:stringprintf",
         "@tsl//tsl/platform:thread_annotations",
         "@tsl//tsl/platform:tracing",
     ],

xla/tsl/platform/default/posix_file_system.cc

@@ -349,7 +349,7 @@ absl::Status PosixFileSystem::CreateDir(const std::string& name,
                                         TransactionToken* token) {
   std::string translated = TranslateName(name);
   if (translated.empty()) {
-    return errors::AlreadyExists(name);
+    return absl::AlreadyExistsError(name);
   }
   if (mkdir(translated.c_str(), 0755) != 0) {
     return IOError(name, errno);

xla/tsl/platform/env.cc

@@ -18,19 +18,30 @@ limitations under the License.
 #include <sys/stat.h>
 
 #include <cstdint>
-#include <deque>
+#include <cstdio>
+#include <memory>
+#include <string>
+#include <unordered_map>
 #include <utility>
 #include <vector>
 
+#include "absl/log/check.h"
+#include "absl/status/status.h"
+#include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
+#include "absl/strings/string_view.h"
 #include "absl/synchronization/mutex.h"
-#include "xla/tsl/platform/env_time.h"
+#include "absl/types/span.h"
+#include "google/protobuf/io/coded_stream.h"
+#include "google/protobuf/io/zero_copy_stream.h"
+#include "google/protobuf/message.h"
+#include "google/protobuf/message_lite.h"
+#include "google/protobuf/text_format.h"
 #include "xla/tsl/platform/errors.h"
+#include "xla/tsl/platform/file_statistics.h"
+#include "xla/tsl/platform/file_system.h"
 #include "tsl/platform/host_info.h"
 #include "tsl/platform/path.h"
-#include "tsl/platform/platform.h"
-#include "tsl/platform/protobuf.h"
-#include "tsl/platform/stringprintf.h"
 #include "tsl/platform/thread_annotations.h"
 
 #if defined(__APPLE__)
@@ -77,8 +88,8 @@ absl::Status FileSystemRegistryImpl::Register(
   absl::MutexLock lock(mu_);
   if (!registry_.emplace(scheme, std::unique_ptr<FileSystem>(factory()))
            .second) {
-    return errors::AlreadyExists("File factory for ", scheme,
-                                 " already registered");
+    return absl::AlreadyExistsError(
+        absl::StrCat("File factory for ", scheme, " already registered"));
   }
   return absl::OkStatus();
 }
@@ -87,8 +98,8 @@ absl::Status FileSystemRegistryImpl::Register(
     const std::string& scheme, std::unique_ptr<FileSystem> filesystem) {
   absl::MutexLock lock(mu_);
   if (!registry_.emplace(scheme, std::move(filesystem)).second) {
-    return errors::AlreadyExists("File system for ", scheme,
-                                 " already registered");
+    return absl::AlreadyExistsError(
+        absl::StrCat("File system for ", scheme, " already registered"));
   }
   return absl::OkStatus();
 }

xla/tsl/platform/ram_file_system.h

@@ -263,7 +263,7 @@ class RamFileSystem : public FileSystem {
 
     auto it = fs_.find(dirname);
     if (it != fs_.end() && it->second != nullptr) {
-      return errors::AlreadyExists(
+      return absl::AlreadyExistsError(
           "cannot create directory with same name as an existing file");
     }
 

xla/tsl/platform/windows/windows_file_system.cc

@@ -594,7 +594,7 @@ Status WindowsFileSystem::CreateDir(const string& name,
   Status result;
   std::wstring ws_name = Utf8ToWideChar(name);
   if (ws_name.empty()) {
-    return errors::AlreadyExists(name);
+    return absl::AlreadyExistsError(name);
   }
   if (_wmkdir(ws_name.c_str()) != 0) {
     result = IOError("Failed to create a directory: " + name, errno);