Skip to content

Commit cce2185

Browse files
nvgrwGoogle-ML-Automation
authored andcommitted
Tag PjRt migration candidates explicitly. (BUILD changes)
This change adds a new tag "pjrt_migration_candidate" to all test targets that depend on HloTestBase, ClientLibraryTestBase, and HloRunnerTpuSystem. This change also adds a new `use_legacy_runtime` kwarg to `xla_test`, which acts as a replacement for "test_migrated_to_hlo_runner_pjrt". During a brief transition phase, we will leave all "test_migrated_to_hlo_runner_pjrt" tags in place so that we can identify any tests that have the `use_legacy_runtime` set to an incorrect value. "pjrt_migration_candidate" and "test_migrated_to_hlo_runner_pjrt" are mutually exclusive. "pjrt_migration_candidate" should not appear on any tests using the new runtime. Unlike "test_migrated_to_hlo_runner_pjrt", which primarily tags `xla_test` targets, "pjrt_migration_candidate" intends to tag all outstanding migration candidates to obtain an accurate picture of migration progress. If a test cannot or should not be migrated, it can be excluded from any analysis just by removing the tag. PiperOrigin-RevId: 852941492
1 parent b1ee739 commit cce2185

File tree

1 file changed

+8
-0
lines changed
  • xla/backends/gpu/runtime

1 file changed

+8
-0
lines changed

xla/backends/gpu/runtime/BUILD

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -955,6 +955,8 @@ xla_test(
955955
name = "gpublas_lt_matmul_thunk_test",
956956
srcs = ["gpublas_lt_matmul_thunk_test.cc"],
957957
backends = ["gpu"],
958+
tags = ["pjrt_migration_candidate"],
959+
use_legacy_runtime = True,
958960
deps = [
959961
":gpublas_lt_matmul_thunk",
960962
":thunk",
@@ -1634,6 +1636,8 @@ xla_test(
16341636
name = "collective_broadcast_thunk_test",
16351637
srcs = ["collective_broadcast_thunk_test.cc"],
16361638
backends = ["gpu"],
1639+
tags = ["pjrt_migration_candidate"],
1640+
use_legacy_runtime = True,
16371641
deps = [
16381642
":collective_broadcast_thunk",
16391643
":collective_thunk",
@@ -1718,6 +1722,8 @@ xla_test(
17181722
name = "collective_permute_thunk_test",
17191723
srcs = ["collective_permute_thunk_test.cc"],
17201724
backends = ["gpu"],
1725+
tags = ["pjrt_migration_candidate"],
1726+
use_legacy_runtime = True,
17211727
deps = [
17221728
":collective_permute_thunk",
17231729
":collective_thunk",
@@ -3594,6 +3600,8 @@ xla_test(
35943600
name = "runtime_intrinsics_test",
35953601
srcs = ["runtime_intrinsics_test.cc"],
35963602
backends = ["gpu"],
3603+
tags = ["pjrt_migration_candidate"],
3604+
use_legacy_runtime = True,
35973605
deps = [
35983606
":runtime_intrinsics",
35993607
"//xla:literal",

0 commit comments

Comments
 (0)