[Cleanup] Use push_back instead of emplace_back where appropriate (go/totw/112)

PiperOrigin-RevId: 708167009

Author: frgossen

xla/python/xplane_to_profile_instructions.cc

@@ -117,7 +117,7 @@ void GetXPlaneLatencyInfo(
       if (fingerprint.has_value()) {
         key = absl::StrCat(fingerprint.value(), kCostNameSep, hlo_name.value());
       }
-      (*hlo_latency_info)[key].durations.emplace_back(latency);
+      (*hlo_latency_info)[key].durations.push_back(latency);
     });
   });
 }
@@ -194,7 +194,7 @@ absl::Status ConvertXplaneUnderLogdirToProfiledInstructionsProto(
       tensorflow::profiler::XSpace xspace;
       TF_RETURN_IF_ERROR(
           ReadBinaryProto(tsl::Env::Default(), xspace_path, &xspace));
-      xspaces.emplace_back(xspace);
+      xspaces.push_back(xspace);
     }
   }
 

xla/service/heap_simulator/heap_simulator.cc

@@ -2334,7 +2334,7 @@ GlobalDecreasingSizeBestFitHeap<BufferType>::Finish() {
   VLOG(1) << "result heap_size: " << result_.heap_size;
   Result result;
   result.heap_size = result_.heap_size;
-  result.heap_results.emplace_back(result_);
+  result.heap_results.push_back(result_);
   return result;
 }
 

xla/service/memory_space_assignment/algorithm.cc

@@ -286,11 +286,11 @@ std::vector<MsaBufferInterval> FindCrossProgramPrefetchCandidates(
     interval.need_allocation = true;
     interval.colocations = {++buffer.values().begin(), buffer.values().end()};
     if (IsCrossProgramPrefetchCandidate(*value, alias_analysis, options)) {
-      candidates.emplace_back(interval);
+      candidates.push_back(interval);
     } else if (MemorySpaceAssignmentUtils::
                    DoesCrossProgramPrefetchBufferMatchAnyFilter(
                        options.msa_sort_order_overrides, interval)) {
-      candidates.emplace_back(interval);
+      candidates.push_back(interval);
     }
   }
 

xla/service/memory_space_assignment/best_fit_repacker.cc

@@ -507,7 +507,7 @@ class BestFitRepacker
 
     Result result;
     result.heap_size = result_.heap_size;
-    result.heap_results.emplace_back(result_);
+    result.heap_results.push_back(result_);
     return result;
   }