zpool: fix conflict with -v and -o options #17839
Open
+86
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Work in Progress
github-actions
bot
added
Status: Code Review Needed
robn
approved these changes
Oct 13, 2025
amotin
reviewed
Oct 13, 2025
Fixes openzfs#11040. Right now, the -v and -o options for `zpool list` work independently, but when paired, the -v "wins out" and the -o effect is lost. This commit fixes that problem. Signed-off-by: Shreshth Srivastava <[email protected]>
Shreshth3
force-pushed
the
v-o-option-conflict
branch
from
0ed555e to
4c1785c
Compare
Shreshth3
commented
Oct 17, 2025
amotin
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Looking closer, while it does look like a step in a right direction, I think we should go further now. For example, dedup field has nothing to do with vdevs, but it is present in this code. Same time bclone_ratio absent here is not printed properly:
mav@genoa2:~# zpool list -v -o name,dedup,bclone_ratio,health optane
NAME DEDUP BCLONE_RATIO HEALTH
optane 1.00x 1.00x ONLINE
nvd0p1 - ONLINE
nvd10p1 - ONLINE
nvd11p1 - ONLINE
nvd12p1 - ONLINE
nvd13p1 - ONLINE
nvd1p1 - ONLINE
nvd2p1 - ONLINE
nvd3p1 - ONLINE
nvd4p1 - ONLINE
nvd5p1 - ONLINE
nvd6p1 - ONLINE
nvd7p1 - ONLINE
nvd8p1 - ONLINE
nvd9p1 - ONLINE
Can we remove explicit mention of not applicable properties, but instead handle them all universally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11040.
Right now, the -v and -o options for
zpool listwork independently, but when paired, the -v "wins out" and the -o effect is lost. This commit fixes that problem.Before my change:
(master) ~/zfs$ ./zpool list -v -o name,health mypool NAME HEALTH mypool ONLINE mirror-0 960M 110K 960M - - 2% 0.01% - ONLINE loop17 1G - - - - - - - ONLINE loop18 1G - - - - - - - ONLINEAfter my change:
(v-o-option-conflict) ~/zfs$ ./zpool list -v -o name,health mypool NAME HEALTH mypool ONLINE mirror-0 ONLINE loop17 ONLINE loop18 ONLINETypes of changes
Checklist:
Signed-off-by.