Skip to content

Commit 17f806d

Browse files
author
renaud gaudin
committed
Allow chaining Query().set_query()
As is done on libzim, return self on set_query() so one can initialize a query with a single `query = Query().set_query("foo")` instead of two
1 parent c6c2aba commit 17f806d

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

libzim/libzim.pyx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -947,6 +947,7 @@ cdef class Query:
947947

948948
def set_query(self, query: str):
949949
self.c_query.setQuery(query.encode('UTF-8'))
950+
return self
950951

951952

952953
cdef class SearchResultSet:
@@ -1033,8 +1034,7 @@ Usage:
10331034
10341035
archive = libzim.reader.Archive(fpath)
10351036
searcher = Searcher(archive)
1036-
query = Query()
1037-
query.setQuery("foo")
1037+
query = Query().setQuery("foo")
10381038
search = searcher.search(query)
10391039
for path in search.getResult(10, 10) # get result from 10 to 20 (10 results)
10401040
print(path, archive.get_entry_by_path(path).title)"""

tests/test_libzim_reader.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,8 +407,7 @@ def test_reader_suggest_search(
407407
assert zim.article_count == article_count
408408

409409
if search_string is not None:
410-
query = Query()
411-
query.set_query(search_string)
410+
query = Query().set_query(search_string)
412411
searcher = Searcher(zim)
413412
search = searcher.search(query)
414413
assert search.getEstimatedMatches() == search_count

0 commit comments

Comments
 (0)