Merge pull request #151 from openzim/nolzma

Remove lzma compression option

Author: mgautierfr

CHANGELOG.md

@@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- n/a
+### Removed
+
+- Removed `lzma` compression option (#150)
 
 ## [1.1.1] – 2022-06-17
 

libzim/libwrapper.cpp

@@ -172,8 +172,6 @@ zim::Compression comp_from_int(int compValue)
     case 0:
       return zim::Compression::None;
     case 1:
-      return zim::Compression::Lzma;
-    case 2:
       return zim::Compression::Zstd;
     default:
       // Should we raise an error ?

libzim/libzim.pyx

@@ -190,8 +190,7 @@ class Compression(enum.Enum):
     # We don't care of the exact value. The function comp_from_int will do the right
     # conversion to zim::Compression
     none = 0
-    lzma = 1
-    zstd = 2
+    zstd = 1
 
 
 class Hint(enum.Enum):

libzim/zim.pxd

@@ -35,7 +35,6 @@ cdef extern from "zim/zim.h" namespace "zim":
         # We need to declare something here to be syntaxically correct
         # but we don't use those values (even if they are valid).
         None "zim::Compression::None"
-        Lzma "zim::Compression::Lzma"
         Zstd "zim::Compression::Zstd"
 
 

tests/test_libzim_creator.py

@@ -254,7 +254,7 @@ def test_creator_nbworkers(fpath, lipsum_item, nb_workers):
 
 def test_creator_combine_config(fpath, lipsum_item):
     with Creator(fpath).config_verbose(True).config_compression(
-        "lzma"
+        "zstd"
     ).config_clustersize(1024).config_indexing(True, "eng").config_nbworkers(2) as c:
         c.add_item(lipsum_item)
 
@@ -263,7 +263,7 @@ def test_creator_combine_config(fpath, lipsum_item):
     "name, args",
     [
         ("verbose", (True,)),
-        ("compression", ("lzma",)),
+        ("compression", ("zstd",)),
         ("clustersize", (1024,)),
         ("indexing", (True, "eng")),
         ("nbworkers", (2,)),