Run our lint command.

Author: mgautierfr

examples/basic_writer.py

@@ -20,7 +20,7 @@
 import uuid
 
 from libzim.reader import Archive
-from libzim.writer import Item, StringProvider, Creator
+from libzim.writer import Creator, Item, StringProvider
 
 
 class TestItem(Item):

libzim/libzim.pyx

@@ -31,27 +31,27 @@ __path__ = []
 
 cimport zim
 
-import os
+import datetime
 import enum
+import importlib
+import os
+import pathlib
+import sys
+import traceback
+from types import ModuleType
+from typing import Dict, Generator, Iterator, List, Set, Union
 from uuid import UUID
-from cpython.ref cimport PyObject
+
 from cpython.buffer cimport PyBUF_WRITABLE
+from cpython.ref cimport PyObject
 from cython.operator import preincrement
 from libc.stdint cimport uint64_t
-from libcpp.string cimport string
 from libcpp cimport bool
-from libcpp.memory cimport shared_ptr
 from libcpp.map cimport map
+from libcpp.memory cimport shared_ptr
+from libcpp.string cimport string
 from libcpp.utility cimport move
 
-from typing import Dict, Union, Generator, List, Set, Iterator
-import datetime
-import pathlib
-import traceback
-from types import ModuleType
-import sys
-import importlib.abc
-
 pybool = type(True)
 pyint = type(1)
 

libzim/zim.pxd

@@ -18,13 +18,12 @@
 # along with this program. If not, see <http://www.gnu.org/licenses/>.
 
 from cpython.ref cimport PyObject
-
 from libc.stdint cimport uint32_t, uint64_t
 from libcpp cimport bool
+from libcpp.map cimport map
 from libcpp.memory cimport shared_ptr
 from libcpp.string cimport string
 from libcpp.vector cimport vector
-from libcpp.map cimport map
 
 
 cdef extern from "zim/zim.h" namespace "zim":

setup.py

@@ -35,15 +35,15 @@
 
 
 import os
-import sys
 import platform
-from pathlib import Path
+import sys
 from ctypes.util import find_library
+from pathlib import Path
 from textwrap import dedent
 
-from setuptools import setup, Extension
 from Cython.Build import cythonize
 from Cython.Distutils.build_ext import new_build_ext as build_ext
+from setuptools import Extension, setup
 
 base_dir = Path(__file__).parent
 
@@ -56,6 +56,7 @@
     define_macros = []
 
 if platform.system() == "Darwin":
+
     class fixed_build_ext(build_ext):
         """Workaround for rpath bug in distutils for OSX."""
 
@@ -68,32 +69,45 @@ def finalize_options(self):
                 for ext in self.extensions:
                     ext.extra_link_args.append("-Wl,-rpath," + path)
             self.rpath[:] = []
-    cmdclass={"build_ext": fixed_build_ext}
+
+    cmdclass = {"build_ext": fixed_build_ext}
     dyn_lib_ext = "dylib"
 else:
-    cmdclass={"build_ext": build_ext}
+    cmdclass = {"build_ext": build_ext}
     dyn_lib_ext = "so"
 
 include_dirs = ["libzim"]
 library_dirs = []
 # Check for the CPP Libzim library headers in expected directory
-if (base_dir / "include" / "zim" / "zim.h").exists() and (base_dir / "lib" / f"libzim.{dyn_lib_ext}").exists():
-    print(dedent("""\
+header_file = base_dir / "include" / "zim" / "zim.h"
+lib_file = base_dir / "lib" / f"libzim.{dyn_lib_ext}"
+if header_file.exists() and lib_file.exists():
+    print(
+        dedent(
+            """\
         Found lizim library and headers in local directory.
         We will use them to compile python-libzim.
         Hint : If you don't want to use them (and use "system" installed one), remove them.
-    """))
+    """
+        )
+    )
     include_dirs.append("include")
     library_dirs = ["lib"]
 else:
     # Check for library.
     if not find_library("zim"):
-        print(dedent("""\
+        print(
+            dedent(
+                """\
             "[!] The libzim library cannot be found.
             "Please verify that the library is correctly installed of and can be found.
-        """))
+        """
+            )
+        )
         sys.exit(1)
-    print("Using system installed library. We are assuming CFLAGS/LDFLAGS are correctly set.")
+    print(
+        "Using system installed library. We are assuming CFLAGS/LDFLAGS are correctly set."
+    )
 
 wrapper_extension = Extension(
     name="libzim",

tasks.py

@@ -37,7 +37,9 @@ def lint(c):
 
 
 if __name__ == "__main__":
-    print("""\
+    print(
+        """\
 This file is not intended to be directly run.
 Install invoke and run the `invoke` command line.
-""")
+"""
+    )

tests/test_libzim_creator.py

@@ -1,27 +1,26 @@
 #!/usr/bin/env python
 
-import sys
 import base64
-import pathlib
 import datetime
 import itertools
+import pathlib
 import subprocess
+import sys
 from typing import Dict
 
 import pytest
 
 import libzim.writer
+from libzim.reader import Archive
 from libzim.writer import (
-    Creator,
-    Item,
+    Blob,
     ContentProvider,
+    Creator,
     FileProvider,
-    StringProvider,
-    Blob,
     Hint,
+    Item,
+    StringProvider,
 )
-from libzim.reader import Archive
-
 
 HOME_PATH = "lorem_ipsum"
 

tests/test_libzim_reader.py

@@ -1,19 +1,18 @@
 #!/usr/bin/env python
 
-import os
 import gc
-import uuid
+import os
 import pathlib
+import uuid
 from urllib.request import urlretrieve
 
 import pytest
 
 import libzim.writer
 from libzim.reader import Archive
-from libzim.search import Searcher, Query
+from libzim.search import Query, Searcher
 from libzim.suggestion import SuggestionSearcher
 
-
 # expected data for tests ZIMs (see `all_zims`)
 ZIMS_DATA = {
     "blank.zim": {