Merge pull request #162 from openzim/nopascal

Remove pascalize() and its use in add_metadata

Author: rgaudin

CHANGELOG.md

@@ -14,6 +14,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   * `version.print_versions()` print it on stdout (or another fd)
   * `version.get_libzim_version()` returns the libzim version only
 
+### Changed
+
+* `Creator.add_metadata` no longer transforms (~pascalize) name (#161)
+
+### Removed
+
+* `writer.pascalize` function
+
 ## [2.1.0] - 2022-12-06
 
 ### Added

libzim/libzim.pyx

@@ -547,13 +547,6 @@ class BaseWritingItem:
         )
 
 
-def pascalize(keyword: str):
-    """Converts python case to pascal case.
-
-    example: long_description -> LongDescription"""
-    return "".join(keyword.title().split("_"))
-
-
 class Creator(_Creator):
     __module__ = writer_module_name
     def config_compression(self, compression: Compression):
@@ -565,7 +558,6 @@ class Creator(_Creator):
         self, name: str, content: Union[str, bytes, datetime.date, datetime.datetime],
         mimetype: str = "text/plain;charset=UTF-8"
     ):
-        name = pascalize(name)
         if name == "Date" and isinstance(content, (datetime.date, datetime.datetime)):
             content = content.strftime("%Y-%m-%d").encode("UTF-8")
         if isinstance(content, str):
@@ -600,8 +592,7 @@ writer_public_objects = [
     ContentProvider,
     FileProvider,
     StringProvider,
-    IndexData,
-    pascalize
+    IndexData
 ]
 writer = create_module(writer_module_name, writer_module_doc, writer_public_objects)
 

tests/test_libzim_creator.py

@@ -135,12 +135,6 @@ def test_imports():
     assert libzim.writer.Creator  # noqa
 
 
-def test_pascalize():
-    assert libzim.writer.pascalize("title") == "Title"
-    assert libzim.writer.pascalize("my man") == "My Man"
-    assert libzim.writer.pascalize("THATisBAD") == "Thatisbad"
-
-
 def test_creator_filename(fpath):
     with Creator(fpath) as c:
         assert c.filename == fpath