Skip to content

Commit e0a28f9

Browse files
Best2Twoaudiodude
authored andcommitted
modifying test_latest_zim_file_for_builder for testing the fix
1 parent e9a6f52 commit e0a28f9

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

wp1/web/builders.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import logging
2+
import requests
23

34
import flask
45

wp1/web/builders_test.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1287,7 +1287,9 @@ def test_zimfarm_status(self):
12871287
"wp1.logic.builder.zimfarm.zim_file_url_for_task_id",
12881288
return_value="http://fake-file-host.fake/1234/file.zim",
12891289
)
1290-
def test_latest_zim_file_for_builder(self, mock_zimfarm):
1290+
@patch("wp1.web.builders.requests.head")
1291+
def test_latest_zim_file_for_builder(self, mock_head, mock_zimfarm):
1292+
mock_head.return_value.status_code = 200
12911293
builder_id = self._insert_builder()
12921294
self._insert_selections(builder_id)
12931295
self.app = create_app()
@@ -1306,6 +1308,20 @@ def test_latest_zim_file_for_builder_404(self):
13061308
rv = client.get("/v1/builders/abcd-1234/zim/latest")
13071309
self.assertEqual("404 NOT FOUND", rv.status)
13081310

1311+
@patch(
1312+
"wp1.logic.builder.zimfarm.zim_file_url_for_task_id",
1313+
return_value="http://fake-file-host.fake/1234/file.zim",
1314+
)
1315+
@patch("wp1.web.builders.requests.head")
1316+
def test_latest_zim_file_for_builder_410(self, mock_head, mock_zimfarm):
1317+
mock_head.return_value.status_code = 404
1318+
builder_id = self._insert_builder()
1319+
self._insert_selections(builder_id)
1320+
self.app = create_app()
1321+
with self.app.test_client() as client:
1322+
rv = client.get("/v1/builders/%s/zim/latest" % builder_id)
1323+
self.assertEqual("410 GONE", rv.status)
1324+
13091325
def test_latest_selection_article_count_for_builder(self):
13101326
builder_id = self._insert_builder()
13111327
self._insert_selections(builder_id)

0 commit comments

Comments
 (0)