Fix warnings about errors.As parameters

Author: plorenz

ziti/ziti.go

@@ -1607,19 +1607,19 @@ func (context *ContextImpl) createSession(service *rest_model.ServiceDetail, ses
 	session, err := context.getOrCreateSession(*service.ID, sessionType)
 	if err != nil {
 		logger.WithError(err).WithField("errorType", fmt.Sprintf("%T", err)).Warnf("failure creating %s session to service %s", sessionType, *service.Name)
-		var target error = &rest_session.CreateSessionUnauthorized{}
-		if errors.As(err, &target) {
+		var createSessionUnauthorized = &rest_session.CreateSessionUnauthorized{}
+		if errors.As(err, &createSessionUnauthorized) {
 			if err := context.Authenticate(); err != nil {
-				target = &authentication.AuthenticateUnauthorized{}
-				if errors.As(err, &target) {
+				var authenticateUnauthorized = &authentication.AuthenticateUnauthorized{}
+				if errors.As(err, &authenticateUnauthorized) {
 					return nil, backoff.Permanent(err)
 				}
 				return nil, err
 			}
 		}
 
-		target = &rest_session.CreateSessionNotFound{}
-		if errors.As(err, &target) {
+		var createSessionNotFound = &rest_session.CreateSessionNotFound{}
+		if errors.As(err, &createSessionNotFound) {
 			if refreshErr := context.refreshServices(false); refreshErr != nil {
 				logger.WithError(refreshErr).Info("failed to refresh services after create session returned 404 (likely for service)")
 			}
@@ -2042,15 +2042,15 @@ func (mgr *listenerManager) refreshSession() {
 	session, err := mgr.context.refreshSession(mgr.session)
 
 	if err != nil {
-		var target error = &rest_session.DetailSessionNotFound{}
-		if errors.As(err, &target) {
+		var detailSessionNotFound = &rest_session.DetailSessionNotFound{}
+		if errors.As(err, &detailSessionNotFound) {
 			// try to create new session
 			mgr.createSessionWithBackoff()
 			return
 		}
 
-		target = &rest_session.DetailSessionUnauthorized{}
-		if errors.As(err, &target) {
+		var detailSessionUnauthorized = &rest_session.DetailSessionUnauthorized{}
+		if errors.As(err, &detailSessionUnauthorized) {
 			log.WithError(err).Debugf("failure refreshing bind session for service %v", mgr.listener.GetServiceName())
 			if err := mgr.context.EnsureAuthenticated(mgr.options); err != nil {
 				err := fmt.Errorf("unable to establish API session (%w)", err)
@@ -2063,8 +2063,8 @@ func (mgr *listenerManager) refreshSession() {
 
 		session, err = mgr.context.refreshSession(mgr.session)
 		if err != nil {
-			target = &rest_session.DetailSessionUnauthorized{}
-			if errors.As(err, &target) {
+			detailSessionUnauthorized = &rest_session.DetailSessionUnauthorized{}
+			if errors.As(err, &detailSessionUnauthorized) {
 				log.WithError(err).Errorf(
 					"failure refreshing bind session even after re-authenticating api session. service %v",
 					mgr.listener.GetServiceName())