Add license check. Fixes #673 #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
force-pushed
the
license-check
branch
2 times, most recently
from
4358dda to
2247011
Compare
plorenz
force-pushed
the
license-check
branch
from
2247011 to
4589600
Compare
andrewpmartinez
approved these changes
Jan 31, 2025
Member
andrewpmartinez
left a comment
andrewpmartinez
left a comment
There was a problem hiding this comment.
This is ...fine. Ideally, it would have been nice to have a whitelist/blacklist. But that might be hard to maintain.
I assume the idea here is that if the licenses change in any way, someone has to go and add their licenses to the expected list, which hopefully get flagged in a PR.
Member
Author
Yes, exactly. I wouldn't expect that to happen often, since most projects should fall under the set already tracked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.