deprecate channel input because incoming webhooks are now locked to a channel by policy

Author: qrkourier

.github/workflows/zhook.yml

@@ -33,7 +33,6 @@ jobs:
           INPUT_WEBHOOKURL: ${{ secrets.ZHOOK_URL_DEV_NOTIFICATIONS }}
           INPUT_EVENTJSON: ${{ toJson(github.event) }}
           INPUT_SENDERUSERNAME: GitHubZ
-          INPUT_DESTCHANNEL: dev-notifications
           INPUT_SENDERICONURL: https://github.com/fluidicon.png
           ZITI_LOG: 6
           TLSUV_DEBUG: 6
@@ -56,4 +55,3 @@ jobs:
           webhookUrl: ${{ secrets.ZHOOK_URL_DEV_NOTIFICATIONS }}
           eventJson: ${{ toJson(github.event) }}
           senderUsername: GitHubZ
-          destChannel: dev-notifications

README.md

@@ -38,7 +38,6 @@ jobs:
 
         eventJson: ${{ toJson(github.event) }}
         senderUsername: "GitHubZ"
-        destChannel: "github-notifications"
 ```
 
 ### Inputs

action.yml

@@ -8,7 +8,7 @@ inputs:
     description: Identity JSON for an enrolled Ziti endpoint
     required: true
   webhookUrl:
-    description: URL for posting the payload
+    description: Mattermost-channel-specific URL for posting the event
     required: true
   eventJson:
     description: GitHub event JSON (github.event)
@@ -22,9 +22,9 @@ inputs:
     required: false
     default: https://github.com/fluidicon.png
   destChannel:
-    description: Mattermost channel
+    description: Mattermost channel (deprecated because incoming webhooks are now locked to a channel)
     required: false
-    default: dev-notifications
+    default: null
 runs:
   using: docker
   image: Dockerfile

zhook.py

@@ -20,10 +20,9 @@ class MattermostWebhookBody:
   todoColor = "#FFFFFF"
   watchColor = "#FFD700"
 
-  def __init__(self, username, icon, channel, eventName, eventJsonStr, actionRepo):
+  def __init__(self, username, icon, eventName, eventJsonStr, actionRepo):
     self.username = username
     self.icon = icon
-    self.channel = channel
     self.eventName = eventName.lower()
     self.eventJsonStr = eventJsonStr
     self.actionRepo = actionRepo
@@ -36,7 +35,6 @@ def __init__(self, username, icon, channel, eventName, eventJsonStr, actionRepo)
       # "icon_url": self.icon,
       "username": self.senderJson['login'],
       "icon_url": self.senderJson['avatar_url'],
-      "channel": self.channel,
       "props": {"card": f"```json\n{self.eventJsonStr}\n```"},
     }
 
@@ -354,7 +352,6 @@ def dumpJson(self):
   eventJsonStr = os.getenv("INPUT_EVENTJSON")
   username = os.getenv("INPUT_SENDERUSERNAME")
   icon = os.getenv("INPUT_SENDERICONURL")
-  channel = os.getenv("INPUT_DESTCHANNEL")
   actionRepo = os.getenv("GITHUB_ACTION_REPOSITORY")
   eventName = os.getenv("GITHUB_EVENT_NAME")
 
@@ -421,7 +418,7 @@ def generate_json_schema(obj, max_depth=10, current_depth=0):
 
   # Create webhook body
   try:
-    mwb = MattermostWebhookBody(username, icon, channel, eventName, eventJsonStr, actionRepo)
+    mwb = MattermostWebhookBody(username, icon, eventName, eventJsonStr, actionRepo)
   except Exception as e:
     print(f"Exception creating webhook body: {e}")
     raise e