fix: added type checking to null comparisons (#100)

Author: Biki-das

src/http/body.js

@@ -44,7 +44,7 @@ function HttpBody(body, init = {
 	timeout = 0
 } = {}) {
 
-	if (body == null) {
+	if (body === null) {
 		// body is undefined or null
 		body = null;
 	} else if (isURLSearchParams(body)) {

src/http/file-reader.js

@@ -45,7 +45,7 @@ function ZitiFileReader( file ) {
 
     var readEventHandler = function( evt ) {
 
-        if (evt.target.error == null) {
+        if (evt.target.error === null) {
 
             self._offset += evt.target.result.byteLength;
             let buf = new Buffer.from( evt.target.result );

src/http/form-data.js

@@ -156,7 +156,7 @@ ZitiFormData.prototype._trackLength = function(header, value, options) {
   // e.g. for streaming directly from a remote server,
   // w/ a known file a size, and not wanting to wait for
   // incoming file to finish to get its size.
-  if (options.knownLength != null) {
+  if (options.knownLength !== null) {
     valueLength += +options.knownLength;
   } else if (Buffer.isBuffer(value)) {
     valueLength = value.length;
@@ -267,7 +267,7 @@ ZitiFormData.prototype._multiPartHeader = function(field, value, options) {
     header = headers[prop];
 
     // skip nullish headers.
-    if (header == null) {
+    if (header === null) {
       continue;
     }
 

src/http/headers.js

@@ -150,11 +150,11 @@ function HttpHeaders(init = undefined) {
 
 	// We don't worry about converting prop to ByteString here as append()
 	// will handle it.
-	if (init == null) {
+	if (init === null) {
 		// no op
 	} else if (typeof init === 'object') {
 		const method = init[Symbol.iterator];
-		if (method != null) {
+		if (method !== null) {
 			if (typeof method !== 'function') {
 				throw new TypeError('Header pairs must be iterable');
 			}
@@ -393,4 +393,4 @@ HttpHeaders.prototype.createHeadersLenient = function(obj) {
 HttpHeaders.prototype.getAllHeaders = function() {
 	let pairs = getHeaders(this);
 	return pairs;
-}
+}

src/http/internal/errors.js

@@ -197,7 +197,7 @@ class SystemError extends Error {
       // context as the user did.
       Object.defineProperty(this, 'path', {
         get() {
-          return context.path != null ?
+          return context.path !== null ?
             context.path.toString() : context.path;
         },
         set: (value) => {
@@ -212,7 +212,7 @@ class SystemError extends Error {
     if (context.dest !== undefined) {
       Object.defineProperty(this, 'dest', {
         get() {
-          return context.dest != null ?
+          return context.dest !== null ?
             context.dest.toString() : context.dest;
         },
         set: (value) => {
@@ -1057,7 +1057,7 @@ E('ERR_INVALID_ARG_TYPE',
       }
     }
 
-    if (actual == null) {
+    if (actual === null) {
       msg += `. Received ${actual}`;
     } else if (typeof actual === 'function' && actual.name) {
       msg += `. Received function ${actual.name}`;

src/http/internal/util.js

@@ -98,7 +98,7 @@ function assertCrypto() {
 // Move the "slow cases" to a separate function to make sure this function gets
 // inlined properly. That prioritizes the common case.
 function normalizeEncoding(enc) {
-  if (enc == null || enc === 'utf8' || enc === 'utf-8') return 'utf8';
+  if (enc === null || enc === 'utf8' || enc === 'utf-8') return 'utf8';
   return slowCases(enc);
 }
 

src/http/permessage-deflate.js

@@ -111,7 +111,7 @@ class PerMessageDeflate {
     }
     if (this._options.clientMaxWindowBits) {
       params.client_max_window_bits = this._options.clientMaxWindowBits;
-    } else if (this._options.clientMaxWindowBits == null) {
+    } else if (this._options.clientMaxWindowBits === null) {
       params.client_max_window_bits = true;
     }
 

src/http/request.js

@@ -108,11 +108,11 @@ function HttpRequest(serviceNameOrConn, input, init = {}) {
 
 	method = method.toUpperCase();
 
-	if ((init.body != null || isRequest(input) && input.body !== null) && (method === 'GET' || method === 'HEAD')) {
+	if ((init.body !== null || isRequest(input) && input.body !== null) && (method === 'GET' || method === 'HEAD')) {
 		throw new Error('HttpRequest with GET/HEAD method cannot have body');
 	}
 
-	let inputBody = init.body != null ?
+	let inputBody = init.body !== null ?
 		init.body :
 		isRequest(input) && input.body !== null ?
 			clone(input) :
@@ -129,7 +129,7 @@ function HttpRequest(serviceNameOrConn, input, init = {}) {
 		inputBody = this.body;
 	}
 
-	if (inputBody != null && !headers.has('Content-Type')) {
+	if (inputBody !== null && !headers.has('Content-Type')) {
 		const contentType = this.extractContentType(inputBody);
 		if (contentType) {
 			headers.append('Content-Type', contentType);
@@ -283,10 +283,10 @@ HttpRequest.prototype.getRequestOptions = async function() {
 
 	// HTTP-network-or-cache fetch steps 2.4-2.7
 	let contentLengthValue = null;
-	if (this.body == null && /^(POST|PUT)$/i.test(this.getMethod())) {
+	if (this.body === null && /^(POST|PUT)$/i.test(this.getMethod())) {
 		contentLengthValue = '0';
 	}
-	if (this.body != null) {
+	if (this.body !== null) {
 		this.body.get
 		const totalBytes = this.getTotalBytes(this.body);
 		if (typeof totalBytes === 'number') {

src/http/response.js

@@ -49,7 +49,7 @@ function HttpResponse(body = null, opts = {}) {
 	const status = opts.status || 200;
 	const headers = new Headers(opts.headers)
 
-	if (body != null && !headers.has('Content-Type')) {
+	if (body !== null && !headers.has('Content-Type')) {
 		let contentType;
 		try {
 			contentType = extractContentType(body);

src/ui/identity_modal/file-parser.js

@@ -35,7 +35,7 @@ exports.parse = (file) => {
   var chunkReaderBlock = null;
 
   var readEventHandler = function(evt) {
-      if (evt.target.error == null) {
+      if (evt.target.error === null) {
           offset += evt.target.result.length;
           receiveFileChunk(evt.target.result); // callback for handling read chunk
       } else {