add tests

Author: shajia-deshaw

internal/cnpgi/operator/lifecycle_test.go

@@ -340,6 +340,47 @@ var _ = Describe("LifecycleImplementation", func() {
 			Expect(container).To(HaveKey("securityContext"))
 		})
 
+		It("doesn't set security context when it's nil", func(ctx SpecContext) {
+			pod := &corev1.Pod{
+				TypeMeta: podTypeMeta,
+				ObjectMeta: metav1.ObjectMeta{
+					Name: "test-pod",
+				},
+				Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "postgres"}}},
+			}
+			podJSON, _ := json.Marshal(pod)
+			request := &lifecycle.OperatorLifecycleRequest{
+				ObjectDefinition: podJSON,
+			}
+
+			response, err := reconcilePod(ctx, cluster, request, pluginConfiguration, nil, nil, nil)
+			Expect(err).NotTo(HaveOccurred())
+			Expect(response).NotTo(BeNil())
+			Expect(response.JsonPatch).NotTo(BeEmpty())
+
+			var patch []map[string]interface{}
+			err = json.Unmarshal(response.JsonPatch, &patch)
+			Expect(err).NotTo(HaveOccurred())
+
+			var initContainersPatch map[string]interface{}
+			for _, p := range patch {
+				if p["path"] == "/spec/initContainers" && p["op"] == "add" {
+					initContainersPatch = p
+					break
+				}
+			}
+			Expect(initContainersPatch).NotTo(BeNil())
+
+			// Get the init container patch
+			initContainers, ok := initContainersPatch["value"].([]interface{})
+			Expect(ok).To(BeTrue())
+			Expect(initContainers).To(HaveLen(1))
+
+			// Verify the init container doesn't contain the security context
+			container, ok := initContainers[0].(map[string]interface{})
+			Expect(ok).To(BeTrue())
+			Expect(container).NotTo(HaveKey("securityContext"))
+		})
 	})
 
 	Describe("reconcileJob with security context", func() {
@@ -401,5 +442,56 @@ var _ = Describe("LifecycleImplementation", func() {
 			Expect(ok).To(BeTrue())
 			Expect(container).To(HaveKey("securityContext"))
 		})
+
+		It("doesn't set security context when it's nil", func(ctx SpecContext) {
+			job := &batchv1.Job{
+				TypeMeta: jobTypeMeta,
+				ObjectMeta: metav1.ObjectMeta{
+					Name:   "test-job",
+					Labels: map[string]string{},
+				},
+				Spec: batchv1.JobSpec{Template: corev1.PodTemplateSpec{
+					ObjectMeta: metav1.ObjectMeta{
+						Labels: map[string]string{
+							utils.JobRoleLabelName: "full-recovery",
+						},
+					},
+					Spec: corev1.PodSpec{Containers: []corev1.Container{{Name: "full-recovery"}}},
+				}},
+			}
+			jobJSON, _ := json.Marshal(job)
+			request := &lifecycle.OperatorLifecycleRequest{
+				ObjectDefinition: jobJSON,
+			}
+
+			response, err := reconcileJob(ctx, cluster, request, nil, nil, nil)
+			Expect(err).NotTo(HaveOccurred())
+			Expect(response).NotTo(BeNil())
+			Expect(response.JsonPatch).NotTo(BeEmpty())
+
+			var patch []map[string]interface{}
+			err = json.Unmarshal(response.JsonPatch, &patch)
+			Expect(err).NotTo(HaveOccurred())
+			Expect(patch).NotTo(BeEmpty())
+
+			var initContainersPatch map[string]interface{}
+			for _, p := range patch {
+				if p["path"] == "/spec/template/spec/initContainers" && p["op"] == "add" {
+					initContainersPatch = p
+					break
+				}
+			}
+			Expect(initContainersPatch).NotTo(BeNil())
+
+			// Get the init containers patch
+			initContainers, ok := initContainersPatch["value"].([]interface{})
+			Expect(ok).To(BeTrue())
+			Expect(initContainers).To(HaveLen(1))
+
+			// Verify the init container doesn't contain the security context
+			container, ok := initContainers[0].(map[string]interface{})
+			Expect(ok).To(BeTrue())
+			Expect(container).NotTo(HaveKey("securityContext"))
+		})
 	})
 })