Add bundle validation test cases

Signed-off-by: Vu Dinh <[email protected]>

Author: dinhxuanvu

.gitignore

@@ -10,3 +10,9 @@
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
+
+### macOS template
+# General
+*.DS_Store
+.AppleDouble
+.LSOverride

pkg/validation/internal/bundle_test.go

@@ -0,0 +1,75 @@
+package internal
+
+import (
+	"io/ioutil"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/operator-framework/api/pkg/validation/errors"
+	"github.com/operator-framework/operator-registry/pkg/registry"
+	"github.com/stretchr/testify/require"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+
+	k8syaml "k8s.io/apimachinery/pkg/util/yaml"
+)
+
+func TestValidateBundle(t *testing.T) {
+	var table = []struct {
+		description string
+		directory   string
+		hasError    bool
+		errString   string
+	}{
+		{
+			description: "registryv1 bundle/valid bundle",
+			directory:   "./testdata/valid_bundle",
+			hasError:    false,
+		},
+		{
+			description: "registryv1 bundle/valid bundle",
+			directory:   "./testdata/invalid_bundle",
+			hasError:    true,
+			errString:   `owned CRD "etcdclusters.etcd.database.coreos.com" not found in bundle`,
+		},
+		{
+			description: "registryv1 bundle/valid bundle",
+			directory:   "./testdata/invalid_bundle_2",
+			hasError:    true,
+			errString:   `owned CRD "etcdclusters.etcd.database.coreos.com" is present in bundle "test" but not defined in CSV`,
+		},
+	}
+
+	for _, tt := range table {
+		results := []errors.ManifestResult{}
+		unstObjs := []*unstructured.Unstructured{}
+
+		// Read all files in manifests directory
+		items, err := ioutil.ReadDir(tt.directory)
+		require.NoError(t, err, "Unable to read directory: %s", tt.description)
+
+		for _, item := range items {
+			fileWithPath := filepath.Join(tt.directory, item.Name())
+			data, err := ioutil.ReadFile(fileWithPath)
+			require.NoError(t, err, "Unable to read file: %s", fileWithPath)
+
+			dec := k8syaml.NewYAMLOrJSONDecoder(strings.NewReader(string(data)), 30)
+			k8sFile := &unstructured.Unstructured{}
+			err = dec.Decode(k8sFile)
+			require.NoError(t, err, "Unable to decode file: %s", fileWithPath)
+
+			unstObjs = append(unstObjs, k8sFile)
+		}
+
+		// Validate the bundle object
+		bundle := registry.NewBundle("test", "", "", unstObjs...)
+		results = BundleValidator.Validate(bundle)
+
+		if len(results) > 0 {
+			require.Equal(t, results[0].HasError(), tt.hasError)
+			if results[0].HasError() {
+				require.Contains(t, results[0].Errors[0].Error(), tt.errString)
+			}
+		}
+	}
+}

pkg/validation/internal/testdata/invalid_bundle/etcdbackups.etcd.database.coreos.com.crd.yaml

@@ -0,0 +1,13 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: etcdbackups.etcd.database.coreos.com
+spec:
+  group: etcd.database.coreos.com
+  names:
+    kind: EtcdBackup
+    listKind: EtcdBackupList
+    plural: etcdbackups
+    singular: etcdbackup
+  scope: Namespaced
+  version: v1beta2

pkg/validation/internal/testdata/invalid_bundle/etcdoperator.v0.9.4.clusterserviceversion.yaml

@@ -0,0 +1,13 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: etcdrestores.etcd.database.coreos.com
+spec:
+  group: etcd.database.coreos.com
+  names:
+    kind: EtcdRestore
+    listKind: EtcdRestoreList
+    plural: etcdrestores
+    singular: etcdrestore
+  scope: Namespaced
+  version: v1beta2

pkg/validation/internal/testdata/invalid_bundle/etcdrestores.etcd.database.coreos.com.crd.yaml

@@ -0,0 +1,13 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: etcdbackups.etcd.database.coreos.com
+spec:
+  group: etcd.database.coreos.com
+  names:
+    kind: EtcdBackup
+    listKind: EtcdBackupList
+    plural: etcdbackups
+    singular: etcdbackup
+  scope: Namespaced
+  version: v1beta2

pkg/validation/internal/testdata/invalid_bundle_2/etcdbackups.etcd.database.coreos.com.crd.yaml

@@ -0,0 +1,16 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: etcdclusters.etcd.database.coreos.com
+spec:
+  group: etcd.database.coreos.com
+  names:
+    kind: EtcdCluster
+    listKind: EtcdClusterList
+    plural: etcdclusters
+    shortNames:
+    - etcdclus
+    - etcd
+    singular: etcdcluster
+  scope: Namespaced
+  version: v1beta2

pkg/validation/internal/testdata/invalid_bundle_2/etcdclusters.etcd.database.coreos.com.crd.yaml

@@ -0,0 +1,13 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: etcdrestores.etcd.database.coreos.com
+spec:
+  group: etcd.database.coreos.com
+  names:
+    kind: EtcdRestore
+    listKind: EtcdRestoreList
+    plural: etcdrestores
+    singular: etcdrestore
+  scope: Namespaced
+  version: v1beta2

pkg/validation/internal/testdata/invalid_bundle_2/etcdoperator.v0.9.4.clusterserviceversion.yaml

@@ -0,0 +1,13 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: etcdbackups.etcd.database.coreos.com
+spec:
+  group: etcd.database.coreos.com
+  names:
+    kind: EtcdBackup
+    listKind: EtcdBackupList
+    plural: etcdbackups
+    singular: etcdbackup
+  scope: Namespaced
+  version: v1beta2