-
Notifications
You must be signed in to change notification settings - Fork 79
add Release version as an optional field in the CSV #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9966937 to
e9857af
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 37.71% 37.79% +0.08%
==========================================
Files 56 57 +1
Lines 4516 4538 +22
==========================================
+ Hits 1703 1715 +12
- Misses 2661 2669 +8
- Partials 152 154 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f8bf7e2 to
bddcea6
Compare
|
Respects the legacy ability to encode a release version implicitly in semver build metadata when adding a bundle-level Before: ./bin/opm render registry.redhat.io/amq7/amq-broker-rhel8-operator-bundle@sha256:ce274a661f64f3b872b69f2c5b6f6c93f841f456037f69b813ede777c944489b -o yaml | yq 'select(.schema == "olm.bundle").properties[]| select(.type == "olm.package")'type: olm.package
value:
packageName: amq-broker-rhel8
version: 7.10.2-opr-2+0.1676475747.pAfter: ./bin/opm render registry.redhat.io/amq7/amq-broker-rhel8-operator-bundle@sha256:ce274a661f64f3b872b69f2c5b6f6c93f841f456037f69b813ede777c944489b -o yaml | yq 'select(.schema == "olm.bundle").properties[]| select(.type == "olm.package")'type: olm.package
value:
packageName: amq-broker-rhel8
release: 0.1676475747.p
version: 7.10.2-opr-2 |
Signed-off-by: grokspawn <[email protected]> Assisted-by: claude
bddcea6 to
7db47d7
Compare
|
I'm clearing the WIP because I'm hoping to get some reviews/eyes here, but I'm putting on a hold because we want to control the sequence of merges for this and related PRs. /hold |
|
Want to note here that all the off- and on-cluster tooling in o-f and known derivatives is set to unmarshal with tolerance for unknown fields, so the use of this feature with old tooling will result in the field getting dropped/ignored, not a functional impact. |
No description provided.