refactor: rename so that relation between methods is more explicit

Signed-off-by: Chris Laprun <[email protected]>

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java

@@ -474,7 +474,8 @@ default boolean previousAnnotationForDependentResourcesEventFiltering() {
    *
    * @return a Set of resource classes where the previous version annotation won't be used.
    */
-  default Set<Class<? extends HasMetadata>> previousAnnotationUsageBlocklist() {
+  default Set<Class<? extends HasMetadata>>
+      previousAnnotationForDependentResourcesEventFilteringBlocklist() {
     return Set.of(Deployment.class, StatefulSet.class);
   }
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java

@@ -189,9 +189,9 @@ public ConfigurationServiceOverrider withCloneSecondaryResourcesWhenGettingFromC
     return this;
   }
 
-  public ConfigurationServiceOverrider previousAnnotationUsageBlocklist(
-      Set<Class<? extends HasMetadata>> previousAnnotationUsageBlacklist) {
-    this.previousAnnotationUsageBlocklist = previousAnnotationUsageBlacklist;
+  public ConfigurationServiceOverrider withPreviousAnnotationForDependentResourcesBlocklist(
+      Set<Class<? extends HasMetadata>> blocklist) {
+    this.previousAnnotationUsageBlocklist = blocklist;
     return this;
   }
 
@@ -337,10 +337,11 @@ public boolean cloneSecondaryResourcesWhenGettingFromCache() {
       }
 
       @Override
-      public Set<Class<? extends HasMetadata>> previousAnnotationUsageBlocklist() {
+      public Set<Class<? extends HasMetadata>>
+          previousAnnotationForDependentResourcesEventFilteringBlocklist() {
         return overriddenValueOrDefault(
             previousAnnotationUsageBlocklist,
-            ConfigurationService::previousAnnotationUsageBlocklist);
+            ConfigurationService::previousAnnotationForDependentResourcesEventFilteringBlocklist);
       }
     };
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

@@ -173,7 +173,7 @@ private boolean usePreviousAnnotation(Context<P> context) {
               && !context
                   .getControllerConfiguration()
                   .getConfigurationService()
-                  .previousAnnotationUsageBlocklist()
+                  .previousAnnotationForDependentResourcesEventFilteringBlocklist()
                   .contains(this.resourceType());
     }
     return usePreviousAnnotationForEventFiltering;