Skip to content

Commit 1b9c4f4

Browse files
committed
improve: remove misleading log message
This warn message is logged even if missing config is expected Signed-off-by: Attila Mészáros <[email protected]>
1 parent 3723b1c commit 1b9c4f4

File tree

2 files changed

+0
-21
lines changed

2 files changed

+0
-21
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -113,22 +113,9 @@ public <R extends HasMetadata> ControllerConfiguration<R> getConfigurationFor(
113113
Reconciler<R> reconciler) {
114114
final var key = keyFor(reconciler);
115115
final var configuration = configurations.get(key);
116-
if (configuration == null) {
117-
logMissingReconcilerWarning(key, getReconcilersNameMessage());
118-
}
119116
return configuration;
120117
}
121118

122-
protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) {
123-
log.warn("Cannot find reconciler named '{}'. {}", reconcilerKey, reconcilersNameMessage);
124-
}
125-
126-
private String getReconcilersNameMessage() {
127-
return "Known reconcilers: "
128-
+ getKnownReconcilerNames().stream().reduce((s, s2) -> s + ", " + s2).orElse("None")
129-
+ ".";
130-
}
131-
132119
protected <R extends HasMetadata> String keyFor(Reconciler<R> reconciler) {
133120
return ReconcilerUtils.getNameFor(reconciler);
134121
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,6 @@ private static void configureFromAnnotatedReconciler(
147147
}
148148
}
149149

150-
@Override
151-
protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) {
152-
logger.warn(
153-
"Configuration for reconciler '{}' was not found. {}",
154-
reconcilerKey,
155-
reconcilersNameMessage);
156-
}
157-
158150
@SuppressWarnings("unused")
159151
public String getLoggerName() {
160152
return LOGGER_NAME;

0 commit comments

Comments
 (0)