fix: avoid unnecessarily loading classes at build time

Author: metacosm

quarkus-extension/deployment/src/main/java/io/javaoperatorsdk/quarkus/extension/deployment/QuarkusExtensionProcessor.java

@@ -102,27 +102,28 @@ private ControllerConfigurationBuildItem createControllerConfiguration(ClassInfo
             .map(Type::asParameterizedType)
             .orElseThrow(); // shouldn't happen since we're only dealing with ResourceController implementors already
         final var crType = rcInterface.arguments().get(0).name().toString();
-        final Class<?> crClass;
-        try {
-            crClass = Thread.currentThread().getContextClassLoader().loadClass(crType);
-        } catch (ClassNotFoundException e) {
-            throw new IllegalArgumentException("Couldn't find class " + crType);
-        }
 
         // create ResourceController bean
-        additionalBeans.produce(AdditionalBeanBuildItem.unremovableOf(info.name().toString()));
+        final var resourceControllerClassName = info.name().toString();
+        additionalBeans.produce(AdditionalBeanBuildItem.unremovableOf(resourceControllerClassName));
 
         // generate associated Doneable class
         final var doneableClassName = crType + "Doneable";
+        final var crDoneableClassName = CustomResourceDoneable.class.getName();
         try (ClassCreator cc = ClassCreator.builder()
             .classOutput(classOutput)
             .className(doneableClassName)
-            .superClass(CustomResourceDoneable.class)
+            .superClass(crDoneableClassName)
             .build()) {
 
-            MethodCreator ctor = cc.getMethodCreator("<init>", void.class, crClass);
+            MethodCreator ctor = cc.getMethodCreator("<init>", void.class.getName(), crType);
             ctor.setModifiers(Modifier.PUBLIC);
-            ctor.invokeSpecialMethod(MethodDescriptor.ofConstructor(CustomResourceDoneable.class, crClass, Function.class), ctor.getThis(), ctor.getMethodParam(0), ctor.invokeStaticMethod(MethodDescriptor.ofMethod(Function.class, "identity", Function.class)));
+            final var functionName = Function.class.getName();
+            ctor.invokeSpecialMethod(
+                MethodDescriptor.ofConstructor(crDoneableClassName, crType, functionName),
+                ctor.getThis(),
+                ctor.getMethodParam(0),
+                ctor.invokeStaticMethod(MethodDescriptor.ofMethod(functionName, "identity", functionName)));
         }
 
         // generate configuration
@@ -135,7 +136,7 @@ private ControllerConfigurationBuildItem createControllerConfiguration(ClassInfo
             valueOrDefault(controllerAnnotation, "generationAwareEventProcessing", AnnotationValue::asBoolean, () -> true),
             valueOrDefault(controllerAnnotation, "isClusterScoped", AnnotationValue::asBoolean, () -> false),
             valueOrDefault(controllerAnnotation, "namespaces", AnnotationValue::asStringArray, () -> new String[]{}),
-            crClass,
+            crType,
             doneableClassName,
             null // todo: fix-me
         );

quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/QuarkusControllerConfiguration.java

@@ -7,36 +7,30 @@
 import io.fabric8.kubernetes.client.CustomResourceDoneable;
 import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
 import io.javaoperatorsdk.operator.api.config.RetryConfiguration;
+import io.quarkus.runtime.annotations.RecordableConstructor;
 
 public class QuarkusControllerConfiguration<R extends CustomResource> implements ControllerConfiguration<R> {
-    private String name;
-    private String crdName;
-    private String finalizer;
-    private boolean generationAware;
-    private boolean clusterScoped;
-    private Set<String> namespaces;
-    private Class<R> crClass;
-    private Class<CustomResourceDoneable<R>> doneableClass;
-    private boolean watchAllNamespaces;
-    private RetryConfiguration retryConfiguration;
-    
-    // For serialization
-    public QuarkusControllerConfiguration() {
-    }
-    
-    public QuarkusControllerConfiguration(String name, String crdName, String finalizer, boolean generationAware, boolean clusterScoped, String[] namespaces, Class crClass, String doneableClass, RetryConfiguration retryConfiguration) {
+    private final String name;
+    private final String crdName;
+    private final String finalizer;
+    private final boolean generationAware;
+    private final boolean clusterScoped;
+    private final Set<String> namespaces;
+    private final String crClass;
+    private final String doneableClass;
+    private final boolean watchAllNamespaces;
+    private final RetryConfiguration retryConfiguration;
+    
+    @RecordableConstructor
+    public QuarkusControllerConfiguration(String name, String crdName, String finalizer, boolean generationAware, boolean clusterScoped, String[] namespaces, String crClass, String doneableClass, RetryConfiguration retryConfiguration) {
         this.name = name;
         this.crdName = crdName;
         this.finalizer = finalizer;
         this.generationAware = generationAware;
         this.clusterScoped = clusterScoped;
         this.namespaces = namespaces == null || namespaces.length == 0 ? Collections.emptySet() : Set.of(namespaces);
         this.crClass = crClass;
-        try {
-            this.doneableClass = (Class<CustomResourceDoneable<R>>) Thread.currentThread().getContextClassLoader().loadClass(doneableClass);
-        } catch (ClassNotFoundException e) {
-            throw new IllegalArgumentException("Couldn't find class " + doneableClass);
-        }
+        this.doneableClass = doneableClass;
         this.watchAllNamespaces = this.namespaces.contains(WATCH_ALL_NAMESPACES_MARKER);
         this.retryConfiguration = retryConfiguration == null ? ControllerConfiguration.super.getRetryConfiguration() : retryConfiguration;
     }
@@ -63,12 +57,20 @@ public boolean isGenerationAware() {
 
     @Override
     public Class<R> getCustomResourceClass() {
-        return crClass;
+        try {
+            return (Class<R>) Thread.currentThread().getContextClassLoader().loadClass(crClass);
+        } catch (ClassNotFoundException e) {
+            throw new IllegalArgumentException("Couldn't find class " + crClass);
+        }
     }
 
     @Override
     public Class<? extends CustomResourceDoneable<R>> getDoneableClass() {
-        return doneableClass;
+        try {
+            return (Class<CustomResourceDoneable<R>>) Thread.currentThread().getContextClassLoader().loadClass(doneableClass);
+        } catch (ClassNotFoundException e) {
+            throw new IllegalArgumentException("Couldn't find class " + doneableClass);
+        }
     }
 
     @Override
@@ -90,54 +92,4 @@ public boolean watchAllNamespaces() {
     public RetryConfiguration getRetryConfiguration() {
         return retryConfiguration;
     }
-    
-    // For serialization
-    public void setName(String name) {
-        this.name = name;
-    }
-    
-    // For serialization
-    public void setCrdName(String crdName) {
-        this.crdName = crdName;
-    }
-    
-    // For serialization
-    void setFinalizer(String finalizer) {
-        this.finalizer = finalizer;
-    }
-    
-    // For serialization
-    public void setGenerationAware(boolean generationAware) {
-        this.generationAware = generationAware;
-    }
-    
-    // For serialization
-    public void setClusterScoped(boolean clusterScoped) {
-        this.clusterScoped = clusterScoped;
-    }
-    
-    // For serialization
-    public void setNamespaces(Set<String> namespaces) {
-        this.namespaces = namespaces;
-    }
-    
-    // For serialization
-    public void setCrClass(Class<R> crClass) {
-        this.crClass = crClass;
-    }
-    
-    // For serialization
-    public void setDoneableClass(Class<CustomResourceDoneable<R>> doneableClass) {
-        this.doneableClass = doneableClass;
-    }
-    
-    // For serialization
-    public void setWatchAllNamespaces(boolean watchAllNamespaces) {
-        this.watchAllNamespaces = watchAllNamespaces;
-    }
-    
-    // For serialization
-    public void setRetryConfiguration(RetryConfiguration retryConfiguration) {
-        this.retryConfiguration = retryConfiguration;
-    }
 }