Skip to content

Commit 21b9162

Browse files
committed
refactor: remove default deleteResource implementations
1 parent 9ffbca9 commit 21b9162

File tree

5 files changed

+0
-40
lines changed

5 files changed

+0
-40
lines changed

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/runtime/DefaultConfigurationServiceTest.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import io.javaoperatorsdk.operator.ControllerUtils;
1111
import io.javaoperatorsdk.operator.api.Context;
1212
import io.javaoperatorsdk.operator.api.Controller;
13-
import io.javaoperatorsdk.operator.api.DeleteControl;
1413
import io.javaoperatorsdk.operator.api.ResourceController;
1514
import io.javaoperatorsdk.operator.api.UpdateControl;
1615
import org.junit.jupiter.api.Test;
@@ -59,13 +58,6 @@ static class TestCustomFinalizerController
5958
@Version("v1")
6059
public class InnerCustomResource extends CustomResource {}
6160

62-
@Override
63-
public DeleteControl deleteResource(
64-
TestCustomFinalizerController.InnerCustomResource resource,
65-
Context<InnerCustomResource> context) {
66-
return DeleteControl.DEFAULT_DELETE;
67-
}
68-
6961
@Override
7062
public UpdateControl<TestCustomFinalizerController.InnerCustomResource> createOrUpdateResource(
7163
InnerCustomResource resource, Context<InnerCustomResource> context) {
@@ -75,11 +67,6 @@ public UpdateControl<TestCustomFinalizerController.InnerCustomResource> createOr
7567

7668
@Controller(generationAwareEventProcessing = false, name = "test")
7769
static class TestCustomResourceController implements ResourceController<TestCustomResource> {
78-
@Override
79-
public DeleteControl deleteResource(
80-
TestCustomResource resource, Context<TestCustomResource> context) {
81-
return DeleteControl.DEFAULT_DELETE;
82-
}
8370

8471
@Override
8572
public UpdateControl<TestCustomResource> createOrUpdateResource(

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/doubleupdate/DoubleUpdateTestCustomResourceController.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@ public class DoubleUpdateTestCustomResourceController
1717
public static final String TEST_ANNOTATION_VALUE = "TestAnnotationValue";
1818
private final AtomicInteger numberOfExecutions = new AtomicInteger(0);
1919

20-
@Override
21-
public DeleteControl deleteResource(
22-
DoubleUpdateTestCustomResource resource, Context<DoubleUpdateTestCustomResource> context) {
23-
return DeleteControl.DEFAULT_DELETE;
24-
}
25-
2620
@Override
2721
public UpdateControl<DoubleUpdateTestCustomResource> createOrUpdateResource(
2822
DoubleUpdateTestCustomResource resource, Context<DoubleUpdateTestCustomResource> context) {

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/event/EventSourceTestCustomResourceController.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import io.javaoperatorsdk.operator.TestExecutionInfoProvider;
66
import io.javaoperatorsdk.operator.api.Context;
77
import io.javaoperatorsdk.operator.api.Controller;
8-
import io.javaoperatorsdk.operator.api.DeleteControl;
98
import io.javaoperatorsdk.operator.api.ResourceController;
109
import io.javaoperatorsdk.operator.api.UpdateControl;
1110
import io.javaoperatorsdk.operator.processing.event.EventSourceManager;
@@ -33,12 +32,6 @@ public void init(EventSourceManager eventSourceManager) {
3332
eventSourceManager.registerEventSource("Timer", timerEventSource);
3433
}
3534

36-
@Override
37-
public DeleteControl deleteResource(
38-
EventSourceTestCustomResource resource, Context<EventSourceTestCustomResource> context) {
39-
return DeleteControl.DEFAULT_DELETE;
40-
}
41-
4235
@Override
4336
public UpdateControl<EventSourceTestCustomResource> createOrUpdateResource(
4437
EventSourceTestCustomResource resource, Context<EventSourceTestCustomResource> context) {

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/retry/RetryTestCustomResourceController.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import io.javaoperatorsdk.operator.TestExecutionInfoProvider;
66
import io.javaoperatorsdk.operator.api.Context;
77
import io.javaoperatorsdk.operator.api.Controller;
8-
import io.javaoperatorsdk.operator.api.DeleteControl;
98
import io.javaoperatorsdk.operator.api.ResourceController;
109
import io.javaoperatorsdk.operator.api.UpdateControl;
1110
import java.util.concurrent.atomic.AtomicInteger;
@@ -25,12 +24,6 @@ public class RetryTestCustomResourceController
2524
LoggerFactory.getLogger(RetryTestCustomResourceController.class);
2625
private final AtomicInteger numberOfExecutions = new AtomicInteger(0);
2726

28-
@Override
29-
public DeleteControl deleteResource(
30-
RetryTestCustomResource resource, Context<RetryTestCustomResource> context) {
31-
return DeleteControl.DEFAULT_DELETE;
32-
}
33-
3427
@Override
3528
public UpdateControl<RetryTestCustomResource> createOrUpdateResource(
3629
RetryTestCustomResource resource, Context<RetryTestCustomResource> context) {

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/subresource/SubResourceTestCustomResourceController.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import io.javaoperatorsdk.operator.TestExecutionInfoProvider;
66
import io.javaoperatorsdk.operator.api.Context;
77
import io.javaoperatorsdk.operator.api.Controller;
8-
import io.javaoperatorsdk.operator.api.DeleteControl;
98
import io.javaoperatorsdk.operator.api.ResourceController;
109
import io.javaoperatorsdk.operator.api.UpdateControl;
1110
import java.util.concurrent.atomic.AtomicInteger;
@@ -23,12 +22,6 @@ public class SubResourceTestCustomResourceController
2322
LoggerFactory.getLogger(SubResourceTestCustomResourceController.class);
2423
private final AtomicInteger numberOfExecutions = new AtomicInteger(0);
2524

26-
@Override
27-
public DeleteControl deleteResource(
28-
SubResourceTestCustomResource resource, Context<SubResourceTestCustomResource> context) {
29-
return DeleteControl.DEFAULT_DELETE;
30-
}
31-
3225
@Override
3326
public UpdateControl<SubResourceTestCustomResource> createOrUpdateResource(
3427
SubResourceTestCustomResource resource, Context<SubResourceTestCustomResource> context) {

0 commit comments

Comments
 (0)