fix: use proper close method signature

This is meant to avoid diamond inheritance issues where we could have
conflicting version of the method if a class implements several
interfaces with a close method.

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/DefaultEventSourceManager.java

@@ -1,5 +1,6 @@
 package io.javaoperatorsdk.operator.processing.event;
 
+import java.io.IOException;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
@@ -110,7 +111,11 @@ public Optional<EventSource> deRegisterEventSource(String name) {
       lock.lock();
       EventSource currentEventSource = eventSources.remove(name);
       if (currentEventSource != null) {
-        currentEventSource.close();
+        try {
+          currentEventSource.close();
+        } catch (IOException e) {
+          throw new RuntimeException(e);
+        }
       }
 
       return Optional.ofNullable(currentEventSource);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventHandler.java

@@ -1,11 +1,12 @@
 package io.javaoperatorsdk.operator.processing.event;
 
 import java.io.Closeable;
+import java.io.IOException;
 
 public interface EventHandler extends Closeable {
 
   void handleEvent(Event event);
 
   @Override
-  default void close() {}
+  default void close() throws IOException {}
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSource.java

@@ -1,6 +1,7 @@
 package io.javaoperatorsdk.operator.processing.event;
 
 import java.io.Closeable;
+import java.io.IOException;
 
 public interface EventSource extends Closeable {
 
@@ -15,7 +16,7 @@ default void start() {}
    * {@link EventSourceManager}.
    */
   @Override
-  default void close() {}
+  default void close() throws IOException {}
 
   void setEventHandler(EventHandler eventHandler);
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java

@@ -1,10 +1,12 @@
 package io.javaoperatorsdk.operator.processing.event;
 
-import io.javaoperatorsdk.operator.OperatorException;
 import java.io.Closeable;
+import java.io.IOException;
 import java.util.Map;
 import java.util.Optional;
 
+import io.javaoperatorsdk.operator.OperatorException;
+
 public interface EventSourceManager extends Closeable {
 
   /**
@@ -35,5 +37,5 @@ Optional<EventSource> deRegisterCustomResourceFromEventSource(
   Map<String, EventSource> getRegisteredEventSources();
 
   @Override
-  default void close() {}
+  default void close() throws IOException {}
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java

@@ -4,6 +4,7 @@
 import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getUID;
 import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getVersion;
 
+import java.io.IOException;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
@@ -68,7 +69,7 @@ public void start() {
   }
 
   @Override
-  public void close() {
+  public void close() throws IOException {
     eventHandler.close();
     for (Watch watch : this.watches) {
       try {

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/DefaultEventSourceManagerTest.java

@@ -8,12 +8,15 @@
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 
+import java.io.IOException;
+import java.util.Map;
+
+import org.junit.jupiter.api.Test;
+
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.TestUtils;
 import io.javaoperatorsdk.operator.processing.DefaultEventHandler;
 import io.javaoperatorsdk.operator.processing.KubernetesResourceUtils;
-import java.util.Map;
-import org.junit.jupiter.api.Test;
 
 class DefaultEventSourceManagerTest {
 
@@ -38,7 +41,7 @@ public void registersEventSource() {
   }
 
   @Test
-  public void closeShouldCascadeToEventSources() {
+  public void closeShouldCascadeToEventSources() throws IOException {
     EventSource eventSource = mock(EventSource.class);
     EventSource eventSource2 = mock(EventSource.class);
     defaultEventSourceManager.registerEventSource(CUSTOM_EVENT_SOURCE_NAME, eventSource);