Skip to content

Commit 3930a37

Browse files
committed
wip
Signed-off-by: Attila Mészáros <[email protected]>
1 parent b890153 commit 3930a37

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,12 @@ private static <P extends HasMetadata> P pollLocalCache(
237237
}
238238
}
239239

240+
/** Adds finalizer using JSON Patch. Retries conflicts and unprocessable content (HTTP 422) */
241+
@SuppressWarnings("unchecked")
242+
public static <P extends HasMetadata> P addFinalizer(Context<P> context, String finalizer) {
243+
return addFinalizer(context.getClient(), context.getPrimaryResource(), finalizer);
244+
}
245+
240246
/** Adds finalizer using JSON Patch. Retries conflicts and unprocessable content (HTTP 422) */
241247
@SuppressWarnings("unchecked")
242248
public static <P extends HasMetadata> P addFinalizer(
@@ -251,6 +257,11 @@ public static <P extends HasMetadata> P addFinalizer(
251257
r -> !r.hasFinalizer(finalizerName));
252258
}
253259

260+
public static <P extends HasMetadata> P removeFinalizer(
261+
Context<P> context, String finalizerName) {
262+
return removeFinalizer(context.getClient(), context.getPrimaryResource(), finalizerName);
263+
}
264+
254265
public static <P extends HasMetadata> P removeFinalizer(
255266
KubernetesClient client, P resource, String finalizerName) {
256267
return conflictRetryingPatch(

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/triggerallevent/onlyreconcile/TriggerReconcilerOnAllEventReconciler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public UpdateControl<TriggerReconcilerOnAllEventCustomResource> reconcile(
5353

5454
if (!primary.isMarkedForDeletion() && getUseFinalizer() && !primary.hasFinalizer(FINALIZER)) {
5555
log.info("Adding finalizer");
56-
PrimaryUpdateAndCacheUtils.addFinalizer(primary, FINALIZER, context);
56+
PrimaryUpdateAndCacheUtils.addFinalizer(context, FINALIZER);
5757
return UpdateControl.noUpdate();
5858
}
5959

@@ -76,7 +76,7 @@ public UpdateControl<TriggerReconcilerOnAllEventCustomResource> reconcile(
7676
setEventOnMarkedForDeletion(true);
7777
if (getUseFinalizer() && primary.hasFinalizer(FINALIZER)) {
7878
log.info("Removing finalizer");
79-
PrimaryUpdateAndCacheUtils.removeFinalizer(primary, FINALIZER, context);
79+
PrimaryUpdateAndCacheUtils.removeFinalizer(context, FINALIZER);
8080
}
8181
}
8282

0 commit comments

Comments
 (0)