Skip to content

Commit 586eb57

Browse files
committed
event scheduler improvements
1 parent 3c92091 commit 586eb57

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

operator-framework/src/main/java/com/github/containersolutions/operator/processing/CustomResourceEvent.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010
import java.util.Optional;
1111

1212
class CustomResourceEvent {
13+
1314
public static final int MAX_RETRY_COUNT = 5;
15+
1416
private final static Logger log = LoggerFactory.getLogger(CustomResourceEvent.class);
1517

1618
private final static BackOffExecution backOff = new ExponentialBackOff(2000L, 1.5).start();
@@ -79,8 +81,8 @@ public String toString() {
7981
return "CustomResourceEvent{" +
8082
"action=" + action +
8183
", resource=[ name=" + resource.getMetadata().getName() + ", kind=" + resource.getKind() +
82-
", apiVersion=" + resource.getApiVersion() + "]" +
83-
", retriesIndex=" + retryIndex +
84+
", apiVersion=" + resource.getApiVersion() + " ,resourceVersion=" + resource.getMetadata().getResourceVersion() +
85+
" ], retriesIndex=" + retryIndex +
8486
'}';
8587
}
8688
}

operator-framework/src/main/java/com/github/containersolutions/operator/processing/EventScheduler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,12 @@ void scheduleEvent(CustomResourceEvent newEvent) {
103103
ScheduledFuture<?> scheduledFuture = scheduleHolder.getScheduledFuture();
104104
// If newEvent is older than existing in queue, don't schedule and remove from cache
105105
if (scheduledEvent.isSameResourceAndNewerVersion(newEvent)) {
106-
log.debug("Incoming event discarded because queued event is newer. {}", newEvent);
106+
log.debug("Incoming event discarded because already scheduled event is newer. {}", newEvent);
107107
return;
108108
}
109109
// If newEvent is newer than existing in queue, cancel and remove queuedEvent
110110
if (newEvent.isSameResourceAndNewerVersion(scheduledEvent)) {
111-
log.debug("Queued event canceled because incoming event is newer. {}", scheduledEvent);
111+
log.debug("Scheduled event canceled because incoming event is newer. {}", scheduledEvent);
112112
scheduledFuture.cancel(false);
113113
eventStore.removeEventScheduledForProcessing(scheduledEvent.resourceUid());
114114
}

0 commit comments

Comments
 (0)