fix: explicit workflow invovation

csviri · csviri · commit 5887fbc31520 · 2025-02-04T15:14:25.000+01:00
Signed-off-by: Attila Mészáros &lt;a_meszaros@apple.com&gt;
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java
@@ -195,7 +195,7 @@ public DeleteControl execute() throws Exception {
 
               // The cleanup is called also when explicit invocation is true, but the cleaner is not
               // implemented
-              if (managedWorkflow.hasCleaner() || !explicitWorkflowInvocation) {
+              if (managedWorkflow.hasCleaner() && !explicitWorkflowInvocation) {
                 workflowCleanupResult = managedWorkflow.cleanup(resource, context);
               }
 

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ public DeleteControl execute() throws Exception {`
`195`	`195`
`196`	`196`	`// The cleanup is called also when explicit invocation is true, but the cleaner is not`
`197`	`197`	`// implemented`
`198`		`- if (managedWorkflow.hasCleaner() \|\| !explicitWorkflowInvocation) {`
	`198`	`+ if (managedWorkflow.hasCleaner() && !explicitWorkflowInvocation) {`
`199`	`199`	`workflowCleanupResult = managedWorkflow.cleanup(resource, context);`
`200`	`200`	`}`
`201`	`201`