fix: make QuarkusControllerConfiguration RecordableConstructor-enabled

This requires:
- each constructor parameter needs to have an associated getter with the
  exact same name and type
- for constructor params to be discovered by Quarkus, Maven compiler
  parameters support needs to be activated
  See https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#parameters
  For some reason, just setting the property wasn't enough, had to
  configure the compiler plugin directly
- a recent Maven compiler plugin, by default, you get 3.1 which doesn't
  support this option

Author: metacosm

quarkus-extension/deployment/src/main/java/io/javaoperatorsdk/quarkus/extension/deployment/QuarkusExtensionProcessor.java

@@ -135,7 +135,7 @@ private ControllerConfigurationBuildItem createControllerConfiguration(ClassInfo
             valueOrDefault(controllerAnnotation, "finalizerName", AnnotationValue::asString, () -> ControllerUtils.getDefaultFinalizerName(crdName)),
             valueOrDefault(controllerAnnotation, "generationAwareEventProcessing", AnnotationValue::asBoolean, () -> true),
             valueOrDefault(controllerAnnotation, "isClusterScoped", AnnotationValue::asBoolean, () -> false),
-            valueOrDefault(controllerAnnotation, "namespaces", AnnotationValue::asStringArray, () -> new String[]{}),
+            QuarkusControllerConfiguration.asSet(valueOrDefault(controllerAnnotation, "namespaces", AnnotationValue::asStringArray, () -> new String[]{})),
             crType,
             doneableClassName,
             null // todo: fix-me

quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/QuarkusControllerConfiguration.java

@@ -17,24 +17,40 @@ public class QuarkusControllerConfiguration<R extends CustomResource> implements
     private final boolean clusterScoped;
     private final Set<String> namespaces;
     private final String crClass;
-    private final String doneableClass;
+    private final String doneableClassName;
     private final boolean watchAllNamespaces;
     private final RetryConfiguration retryConfiguration;
 
     @RecordableConstructor
-    public QuarkusControllerConfiguration(String name, String crdName, String finalizer, boolean generationAware, boolean clusterScoped, String[] namespaces, String crClass, String doneableClass, RetryConfiguration retryConfiguration) {
+    public QuarkusControllerConfiguration(String name, String crdName, String finalizer, boolean generationAware, boolean clusterScoped, Set<String> namespaces, String crClass, String doneableClassName, RetryConfiguration retryConfiguration) {
         this.name = name;
         this.crdName = crdName;
         this.finalizer = finalizer;
         this.generationAware = generationAware;
         this.clusterScoped = clusterScoped;
-        this.namespaces = namespaces == null || namespaces.length == 0 ? Collections.emptySet() : Set.of(namespaces);
+        this.namespaces = namespaces;
         this.crClass = crClass;
-        this.doneableClass = doneableClass;
+        this.doneableClassName = doneableClassName;
         this.watchAllNamespaces = this.namespaces.contains(WATCH_ALL_NAMESPACES_MARKER);
         this.retryConfiguration = retryConfiguration == null ? ControllerConfiguration.super.getRetryConfiguration() : retryConfiguration;
     }
 
+    public static Set<String> asSet(String[] namespaces) {
+        return namespaces == null || namespaces.length == 0 ? Collections.emptySet() : Set.of(namespaces);
+    }
+    
+    public String getCrdName() {
+        return getCRDName();
+    }
+    
+    public String getCrClass() {
+        return crClass;
+    }
+    
+    public String getDoneableClassName() {
+        return doneableClassName;
+    }
+    
     @Override
     public String getName() {
         return name;
@@ -67,9 +83,9 @@ public Class<R> getCustomResourceClass() {
     @Override
     public Class<? extends CustomResourceDoneable<R>> getDoneableClass() {
         try {
-            return (Class<CustomResourceDoneable<R>>) Thread.currentThread().getContextClassLoader().loadClass(doneableClass);
+            return (Class<CustomResourceDoneable<R>>) Thread.currentThread().getContextClassLoader().loadClass(doneableClassName);
         } catch (ClassNotFoundException e) {
-            throw new IllegalArgumentException("Couldn't find class " + doneableClass);
+            throw new IllegalArgumentException("Couldn't find class " + doneableClassName);
         }
     }
 

samples/quarkus/pom.xml

@@ -18,6 +18,8 @@
     <maven.compiler.source>11</maven.compiler.source>
     <maven.compiler.target>11</maven.compiler.target>
     <quarkus.version>1.10.3.Final</quarkus.version>
+    <compiler-plugin.version>3.8.1</compiler-plugin.version>
+    <maven.compiler.parameters>true</maven.compiler.parameters>
   </properties>
 
   <dependencyManagement>
@@ -57,6 +59,14 @@
 
   <build>
     <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>${compiler-plugin.version}</version>
+        <configuration>
+          <parameters>true</parameters>
+        </configuration>
+      </plugin>
       <plugin>
         <groupId>io.quarkus</groupId>
         <artifactId>quarkus-maven-plugin</artifactId>