Skip to content

Commit 7a0b6b7

Browse files
committed
refactor: optimize retrieval of secondary resource
Signed-off-by: Chris Laprun <[email protected]>
1 parent 6eb8fdc commit 7a0b6b7

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ protected ReconcileResult<R> reconcile(P primary, R actualResource, Context<P> c
112112

113113
@Override
114114
public Optional<R> getSecondaryResource(P primary, Context<P> context) {
115-
116115
var secondaryResources = context.getSecondaryResources(resourceType());
117116
if (secondaryResources.isEmpty()) {
118117
return Optional.empty();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package io.javaoperatorsdk.operator.processing.dependent.kubernetes;
22

33
import java.util.Map;
4-
import java.util.Objects;
54
import java.util.Optional;
6-
import java.util.Set;
75

86
import org.slf4j.Logger;
97
import org.slf4j.LoggerFactory;
@@ -264,17 +262,9 @@ protected void addSecondaryToPrimaryMapperAnnotations(
264262
}
265263

266264
@Override
267-
protected Optional<R> selectTargetSecondaryResource(
268-
Set<R> secondaryResources, P primary, Context<P> context) {
269-
ResourceID managedResourceID = targetSecondaryResourceID(primary, context);
270-
return secondaryResources.stream()
271-
.filter(
272-
r ->
273-
r.getMetadata().getName().equals(managedResourceID.getName())
274-
&& Objects.equals(
275-
r.getMetadata().getNamespace(),
276-
managedResourceID.getNamespace().orElse(null)))
277-
.findFirst();
265+
public Optional<R> getSecondaryResource(P primary, Context<P> context) {
266+
final var targetResourceID = targetSecondaryResourceID(primary, context);
267+
return eventSource().flatMap(informer -> informer.get(targetResourceID));
278268
}
279269

280270
/**

0 commit comments

Comments
 (0)