Skip to content

Commit 863ecde

Browse files
committed
wip
Signed-off-by: Attila Mészáros <[email protected]>
1 parent 5667085 commit 863ecde

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/controller/ControllerEventSource.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@ public void onUpdate(T oldCustomResource, T newCustomResource) {
149149

150150
@Override
151151
public void onDelete(T resource, boolean deletedFinalStateUnknown) {
152-
super.onDelete(resource, deletedFinalStateUnknown);
152+
temporaryResourceCache.onDeleteEvent(resource, deletedFinalStateUnknown);
153+
// delete event is quite special here, that requires special care, since we clean up caches on
154+
// delete event.
153155
eventReceived(ResourceAction.DELETED, resource, null, deletedFinalStateUnknown, false);
154156
}
155157

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ public synchronized void onDelete(R resource, boolean b) {
130130
resourceType().getSimpleName());
131131
}
132132
primaryToSecondaryIndex.onDelete(resource);
133-
super.onDelete(resource, b);
133+
temporaryResourceCache.onDeleteEvent(resource, b);
134134
if (acceptedByDeleteFilters(resource, b)) {
135135
propagateEvent(resource);
136136
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,6 @@ protected ManagedInformerEventSource(
7272
this.configuration = configuration;
7373
}
7474

75-
@Override
76-
public void onDelete(R obj, boolean deletedFinalStateUnknown) {
77-
temporaryResourceCache.onDeleteEvent(obj, deletedFinalStateUnknown);
78-
}
79-
8075
protected InformerManager<R, C> manager() {
8176
return cache;
8277
}

0 commit comments

Comments
 (0)