Delete control as enum

Author: csviri

operator-framework/src/main/java/io/javaoperatorsdk/operator/api/DeleteControl.java

@@ -1,18 +1,8 @@
 package io.javaoperatorsdk.operator.api;
 
-public class DeleteControl {
+public enum DeleteControl {
 
-    public static final DeleteControl DEFAULT_DELETE = new DeleteControl(true);
-    public static final DeleteControl NO_FINALIZER_REMOVAL = new DeleteControl(false);
-
-    private final boolean removeFinalizer;
-
-    private DeleteControl(boolean removeFinalizer) {
-        this.removeFinalizer = removeFinalizer;
-    }
-
-    public boolean getRemoveFinalizer() {
-        return removeFinalizer;
-    }
+    DEFAULT_DELETE,
+    NO_FINALIZER_REMOVAL
 
 }

operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/EventDispatcher.java

@@ -106,12 +106,12 @@ private boolean skipBecauseOfGenerations(ExecutionScope executionScope) {
     private PostExecutionControl handleDelete(CustomResource resource, Context context) {
         DeleteControl deleteControl = controller.deleteResource(resource, context);
         boolean hasFinalizer = ControllerUtils.hasGivenFinalizer(resource, resourceFinalizer);
-        if (deleteControl.getRemoveFinalizer() && hasFinalizer) {
+        if (deleteControl == DeleteControl.DEFAULT_DELETE && hasFinalizer) {
             removeFinalizer(resource);
             cleanup(resource);
         } else {
-            log.debug("Skipping finalizer remove. removeFinalizer: {}, hasFinalizer: {} ",
-                    deleteControl.getRemoveFinalizer(), hasFinalizer);
+            log.debug("Skipping finalizer remove. delete control: {}, hasFinalizer: {} ",
+                    deleteControl, hasFinalizer);
         }
         return PostExecutionControl.defaultDispatch();
     }