wip

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

@@ -61,6 +61,11 @@ public class Controller<P extends HasMetadata>
   private static final String RESOURCE = "resource";
   private static final String STATUS = "status";
   private static final String BOTH = "both";
+  public static final String CLEANER_NOT_SUPPORTED_ON_ALL_EVENT_ERROR_MESSAGE =
+      "Cleaner is not supported when triggerReconcilerOnAllEvent enabled.";
+  public static final String
+      MANAGED_WORKFLOWS_NOT_SUPPORTED_TRIGGER_RECONCILER_ON_ALL_EVENT_ERROR_MESSAGE =
+          "Managed workflows are not supported when triggerReconcilerOnAllEvent enabled.";
 
   private final Reconciler<P> reconciler;
   private final ControllerConfiguration<P> configuration;
@@ -97,6 +102,16 @@ public Controller(
     explicitWorkflowInvocation =
         configuration.getWorkflowSpec().map(WorkflowSpec::isExplicitInvocation).orElse(false);
 
+    if (configuration.triggerReconcilerOnAllEvent()) {
+      if (isCleaner) {
+        throw new OperatorException(CLEANER_NOT_SUPPORTED_ON_ALL_EVENT_ERROR_MESSAGE);
+      }
+      if (managedWorkflow != null && !managedWorkflow.isEmpty()) {
+        throw new OperatorException(
+            MANAGED_WORKFLOWS_NOT_SUPPORTED_TRIGGER_RECONCILER_ON_ALL_EVENT_ERROR_MESSAGE);
+      }
+    }
+
     eventSourceManager = new EventSourceManager<>(this);
     eventProcessor = new EventProcessor<>(eventSourceManager, configurationService);
     eventSourceManager.postProcessDefaultEventSourcesAfterProcessorInitializer();

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/ControllerTest.java

@@ -8,6 +8,7 @@
 
 import io.fabric8.kubernetes.api.model.Secret;
 import io.javaoperatorsdk.operator.MockKubernetesClient;
+import io.javaoperatorsdk.operator.OperatorException;
 import io.javaoperatorsdk.operator.api.config.BaseConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import io.javaoperatorsdk.operator.api.config.MockControllerConfiguration;
@@ -23,7 +24,10 @@
 import io.javaoperatorsdk.operator.sample.simple.TestCustomResource;
 
 import static io.javaoperatorsdk.operator.api.monitoring.Metrics.NOOP;
+import static io.javaoperatorsdk.operator.processing.Controller.CLEANER_NOT_SUPPORTED_ON_ALL_EVENT_ERROR_MESSAGE;
+import static io.javaoperatorsdk.operator.processing.Controller.MANAGED_WORKFLOWS_NOT_SUPPORTED_TRIGGER_RECONCILER_ON_ALL_EVENT_ERROR_MESSAGE;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
@@ -76,6 +80,54 @@ void usesFinalizerIfThereIfReconcilerImplementsCleaner() {
     assertThat(controller.useFinalizer()).isTrue();
   }
 
+  @Test
+  void cleanerNotAllowedWithTriggerOnAllEventEnabled() {
+    Reconciler reconciler = mock(Reconciler.class, withSettings().extraInterfaces(Cleaner.class));
+    final var configuration = MockControllerConfiguration.forResource(Secret.class);
+    when(configuration.getConfigurationService()).thenReturn(new BaseConfigurationService());
+    when(configuration.triggerReconcilerOnAllEvent()).thenReturn(true);
+
+    var exception =
+        assertThrows(
+            OperatorException.class,
+            () ->
+                new Controller<Secret>(
+                    reconciler, configuration, MockKubernetesClient.client(Secret.class)));
+
+    assertThat(exception.getMessage()).isEqualTo(CLEANER_NOT_SUPPORTED_ON_ALL_EVENT_ERROR_MESSAGE);
+  }
+
+  @Test
+  void managedWorkflowNotAllowedWithOnAllEventEnabled() {
+    Reconciler reconciler = mock(Reconciler.class);
+    final var configuration = MockControllerConfiguration.forResource(Secret.class);
+
+    var configurationService = mock(ConfigurationService.class);
+    var mockWorkflowFactory = mock(ManagedWorkflowFactory.class);
+    var mockManagedWorkflow = mock(ManagedWorkflow.class);
+
+    when(configuration.getConfigurationService()).thenReturn(configurationService);
+    var workflowSpec = mock(WorkflowSpec.class);
+    when(configuration.getWorkflowSpec()).thenReturn(Optional.of(workflowSpec));
+    when(configurationService.getMetrics()).thenReturn(NOOP);
+    when(configurationService.getWorkflowFactory()).thenReturn(mockWorkflowFactory);
+    when(mockWorkflowFactory.workflowFor(any())).thenReturn(mockManagedWorkflow);
+    var managedWorkflowMock = workflow(true);
+    when(mockManagedWorkflow.resolve(any(), any())).thenReturn(managedWorkflowMock);
+
+    when(configuration.triggerReconcilerOnAllEvent()).thenReturn(true);
+
+    var exception =
+        assertThrows(
+            OperatorException.class,
+            () ->
+                new Controller<Secret>(
+                    reconciler, configuration, MockKubernetesClient.client(Secret.class)));
+
+    assertThat(exception.getMessage())
+        .isEqualTo(MANAGED_WORKFLOWS_NOT_SUPPORTED_TRIGGER_RECONCILER_ON_ALL_EVENT_ERROR_MESSAGE);
+  }
+
   @ParameterizedTest
   @CsvSource({
     "true, true, true, false",
@@ -132,6 +184,7 @@ private Workflow workflow(boolean hasCleaner) {
     var workflow = mock(Workflow.class);
     when(workflow.cleanup(any(), any())).thenReturn(mock(WorkflowCleanupResult.class));
     when(workflow.hasCleaner()).thenReturn(hasCleaner);
+    when(workflow.isEmpty()).thenReturn(false);
     return workflow;
   }
 }