fix: do not output warning when resolving a configuration

Signed-off-by: Chris Laprun <[email protected]>

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

@@ -30,6 +30,12 @@
 
 import static io.javaoperatorsdk.operator.api.config.ControllerConfiguration.CONTROLLER_NAME_AS_FIELD_MANAGER;
 
+/**
+ * A default {@link ConfigurationService} implementation, resolving {@link Reconciler}s
+ * configuration when it has already been resolved before. If this behavior is not adequate, please
+ * use {@link AbstractConfigurationService} instead as a base for your {@code ConfigurationService}
+ * implementation.
+ */
 public class BaseConfigurationService extends AbstractConfigurationService {
 
   private static final String LOGGER_NAME = "Default ConfigurationService implementation";
@@ -149,10 +155,12 @@ private static void configureFromAnnotatedReconciler(
 
   @Override
   protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) {
-    logger.warn(
-        "Configuration for reconciler '{}' was not found. {}",
-        reconcilerKey,
-        reconcilersNameMessage);
+    if (!createIfNeeded()) {
+      logger.warn(
+          "Configuration for reconciler '{}' was not found. {}",
+          reconcilerKey,
+          reconcilersNameMessage);
+    }
   }
 
   @SuppressWarnings("unused")
@@ -318,6 +326,13 @@ private <P extends HasMetadata> ResolvedControllerConfiguration<P> controllerCon
         informerConfig);
   }
 
+  /**
+   * @deprecated This method was meant to allow subclasses to prevent automatic creation of the
+   *     configuration when not found. This functionality is now removed, if you want to be able to
+   *     prevent automated, on-demand creation of a reconciler's configuration, please use the
+   *     {@link AbstractConfigurationService} implementation instead as base for your extension.
+   */
+  @Deprecated(forRemoval = true)
   protected boolean createIfNeeded() {
     return true;
   }

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/BaseConfigurationServiceTest.java

@@ -81,6 +81,13 @@ private static KubernetesDependentResourceConfig extractDependentKubernetesResou
     return (KubernetesDependentResourceConfig) configuration.getConfigurationFor(spec);
   }
 
+  @Test
+  void test() {
+    final var service = new BaseConfigurationService();
+    final var config = service.getConfigurationFor(new NoDepReconciler());
+    System.out.println(config);
+  }
+
   @Test
   @SuppressWarnings({"rawtypes", "unchecked"})
   void getDependentResources() {