Skip to content

Commit b963cc4

Browse files
committed
improve auto configuration support
1 parent 311db65 commit b963cc4

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

spring-boot-starter/src/main/java/com/github/containersolutions/operator/spingboot/starter/OperatorAutoConfiguration.java

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import org.apache.commons.lang3.StringUtils;
1212
import org.slf4j.Logger;
1313
import org.slf4j.LoggerFactory;
14-
import org.springframework.beans.factory.annotation.Autowired;
1514
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
1615
import org.springframework.boot.context.properties.EnableConfigurationProperties;
1716
import org.springframework.context.annotation.Bean;
@@ -21,22 +20,12 @@
2120

2221
@Configuration
2322
@EnableConfigurationProperties({OperatorProperties.class, RetryProperties.class})
24-
@ConditionalOnMissingBean(Operator.class)
2523
public class OperatorAutoConfiguration {
2624
private static final Logger log = LoggerFactory.getLogger(OperatorAutoConfiguration.class);
2725

28-
@Autowired
29-
private RetryProperties retryProperties;
30-
31-
@Autowired
32-
private OperatorProperties operatorProperties;
33-
34-
@Autowired
35-
private List<ResourceController> resourceControllers;
36-
3726
@Bean
3827
@ConditionalOnMissingBean
39-
public KubernetesClient kubernetesClient() {
28+
public KubernetesClient kubernetesClient(OperatorProperties operatorProperties) {
4029
ConfigBuilder config = new ConfigBuilder();
4130
config.withTrustCerts(operatorProperties.isTrustSelfSignedCertificates());
4231
if (StringUtils.isNotBlank(operatorProperties.getUsername())) {
@@ -53,15 +42,16 @@ public KubernetesClient kubernetesClient() {
5342
}
5443

5544
@Bean
56-
public Operator operator(KubernetesClient kubernetesClient, Retry retry) {
45+
@ConditionalOnMissingBean(Operator.class)
46+
public Operator operator(KubernetesClient kubernetesClient, Retry retry, List<ResourceController> resourceControllers) {
5747
Operator operator = new Operator(kubernetesClient);
5848
resourceControllers.forEach(r -> operator.registerControllerForAllNamespaces(r, retry));
5949
return operator;
6050
}
6151

6252
@Bean
6353
@ConditionalOnMissingBean
64-
public Retry retry() {
54+
public Retry retry(RetryProperties retryProperties) {
6555
GenericRetry retry = new GenericRetry();
6656
if (retryProperties.getInitialInterval() != null) {
6757
retry.setInitialInterval(retryProperties.getInitialInterval());

0 commit comments

Comments
 (0)