Skip to content

Commit c929fde

Browse files
committed
Fix lint error
Signed-off-by: 10000-ki <[email protected]>
1 parent 2124e48 commit c929fde

File tree

3 files changed

+26
-26
lines changed

3 files changed

+26
-26
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ public interface ConfigurationService {
5656
* </p>
5757
*
5858
* @param baseConfiguration the {@link ConfigurationService} to start from
59-
* @param overrider the {@link ConfigurationServiceOverrider} used to change the values provided
60-
* by the base configuration
59+
* @param overrider the {@link ConfigurationServiceOverrider} used to change the values
60+
* provided by the base configuration
6161
* @return a new {@link ConfigurationService} starting from the configuration provided as base but
62-
* with overridden values.
62+
* with overridden values.
6363
*/
6464
static ConfigurationService newOverriddenConfigurationService(
6565
ConfigurationService baseConfiguration,
@@ -86,9 +86,9 @@ static ConfigurationService newOverriddenConfigurationService(
8686
* </p>
8787
*
8888
* @param overrider the {@link ConfigurationServiceOverrider} used to change the values provided
89-
* by the default configuration
89+
* by the default configuration
9090
* @return a new {@link ConfigurationService} overriding the default values with the ones provided
91-
* by the specified {@link ConfigurationServiceOverrider}
91+
* by the specified {@link ConfigurationServiceOverrider}
9292
* @since 4.4.0
9393
*/
9494
static ConfigurationService newOverriddenConfigurationService(
@@ -100,9 +100,9 @@ static ConfigurationService newOverriddenConfigurationService(
100100
* Retrieves the configuration associated with the specified reconciler
101101
*
102102
* @param reconciler the reconciler we want the configuration of
103-
* @param <R> the {@code CustomResource} type associated with the specified reconciler
104-
* @return the {@link ControllerConfiguration} associated with the specified reconciler or {@code
105-
* null} if no configuration exists for the reconciler
103+
* @param <R> the {@code CustomResource} type associated with the specified reconciler
104+
* @return the {@link ControllerConfiguration} associated with the specified reconciler or
105+
* {@code null} if no configuration exists for the reconciler
106106
*/
107107
<R extends HasMetadata> ControllerConfiguration<R> getConfigurationFor(Reconciler<R> reconciler);
108108

@@ -223,7 +223,7 @@ default Metrics getMetrics() {
223223
* handle concurrent reconciliations
224224
*
225225
* @return the {@link ExecutorService} implementation to use for concurrent reconciliation
226-
* processing
226+
* processing
227227
*/
228228
default ExecutorService getExecutorService() {
229229
return Executors.newFixedThreadPool(concurrentReconciliationThreads());
@@ -251,7 +251,8 @@ default boolean closeClientOnStop() {
251251

252252
/**
253253
* Override to provide a custom {@link DependentResourceFactory} implementation to change how
254-
* {@link io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource} are instantiated
254+
* {@link io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource} are
255+
* instantiated
255256
*
256257
* @return the custom {@link DependentResourceFactory} implementation
257258
*/
@@ -300,8 +301,8 @@ default Duration cacheSyncTimeout() {
300301
}
301302

302303
/**
303-
* This is the timeout value that allows the reconciliation threads to gracefully shut down.
304-
* If no value is set, the default is immediate shutdown.
304+
* This is the timeout value that allows the reconciliation threads to gracefully shut down. If no
305+
* value is set, the default is immediate shutdown.
305306
*
306307
* @return The duration of time to wait before terminating the reconciliation threads
307308
*/
@@ -363,9 +364,8 @@ default ExecutorServiceManager getExecutorServiceManager() {
363364
* SSA based create/update can be still used with the legacy matching, just overriding the match
364365
* method of Kubernetes Dependent Resource.
365366
*
366-
* @since 4.4.0
367-
*
368367
* @return if SSA should be used for dependent resources
368+
* @since 4.4.0
369369
*/
370370
default boolean ssaBasedCreateUpdateMatchForDependentResources() {
371371
return true;
@@ -393,9 +393,8 @@ default Set<Class<? extends HasMetadata>> defaultNonSSAResource() {
393393
* <p>
394394
* Disable this if you want to react to your own dependent resource updates
395395
*
396-
* @since 4.5.0
397-
*
398396
* @return if special annotation should be used for dependent resource to filter events
397+
* @since 4.5.0
399398
*/
400399
default boolean previousAnnotationForDependentResourcesEventFiltering() {
401400
return true;
@@ -410,9 +409,8 @@ default boolean previousAnnotationForDependentResourcesEventFiltering() {
410409
* logic, and you want to further minimize the amount of work done / updates issued by the
411410
* operator.
412411
*
413-
* @since 4.5.0
414-
*
415412
* @return if resource version should be parsed (as integer)
413+
* @since 4.5.0
416414
*/
417415
default boolean parseResourceVersionsForEventFilteringAndCaching() {
418416
return false;
@@ -424,9 +422,9 @@ default boolean parseResourceVersionsForEventFilteringAndCaching() {
424422
* adding finalizers, patching resources and status.
425423
*
426424
* @return {@code true} if Server-Side Apply (SSA) should be used when patching the primary
427-
* resources, {@code false} otherwise
428-
* @since 5.0.0
425+
* resources, {@code false} otherwise
429426
* @see ConfigurationServiceOverrider#withUseSSAToPatchPrimaryResource(boolean)
427+
* @since 5.0.0
430428
*/
431429
default boolean useSSAToPatchPrimaryResource() {
432430
return true;
@@ -447,8 +445,7 @@ default boolean useSSAToPatchPrimaryResource() {
447445
* </p>
448446
*
449447
* @return {@code true} if resources should be defensively cloned before returning them from
450-
* caches, {@code false} otherwise
451-
*
448+
* caches, {@code false} otherwise
452449
* @since 5.0.0
453450
*/
454451
default boolean cloneSecondaryResourcesWhenGettingFromCache() {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import io.javaoperatorsdk.operator.api.monitoring.Metrics;
1515
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResourceFactory;
1616

17-
@SuppressWarnings({"unused", "UnusedReturnValue"})
17+
@SuppressWarnings( {"unused", "UnusedReturnValue"})
1818
public class ConfigurationServiceOverrider {
1919

2020
private static final Logger log = LoggerFactory.getLogger(ConfigurationServiceOverrider.class);

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverriderTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313

1414
class ConfigurationServiceOverriderTest {
1515

16-
private static final Metrics METRICS = new Metrics() {};
16+
private static final Metrics METRICS = new Metrics() {
17+
};
1718

1819
private static final LeaderElectionConfiguration LEADER_ELECTION_CONFIGURATION =
1920
new LeaderElectionConfiguration("foo", "fooNS");
@@ -60,7 +61,8 @@ public <R extends HasMetadata> R clone(R object) {
6061
}
6162
})
6263
.withConcurrentReconciliationThreads(25)
63-
.withMetrics(new Metrics() {})
64+
.withMetrics(new Metrics() {
65+
})
6466
.withLeaderElectionConfiguration(new LeaderElectionConfiguration("newLease", "newLeaseNS"))
6567
.withInformerStoppedHandler((informer, ex) -> {
6668
})
@@ -79,7 +81,8 @@ public <R extends HasMetadata> R clone(R object) {
7981
overridden.getLeaderElectionConfiguration());
8082
assertNotEquals(config.getInformerStoppedHandler(),
8183
overridden.getLeaderElectionConfiguration());
82-
assertNotEquals(config.reconciliationTerminationTimeout(), overridden.reconciliationTerminationTimeout());
84+
assertNotEquals(config.reconciliationTerminationTimeout(),
85+
overridden.reconciliationTerminationTimeout());
8386
}
8487

8588
}

0 commit comments

Comments
 (0)