Design complex test fixtures

Author: Soroosh Sarabadani

operator-framework/src/test/resources/AbstractController.java

@@ -1,26 +1,14 @@
 package io;
 
 import io.fabric8.kubernetes.client.CustomResource;
-import io.fabric8.kubernetes.client.CustomResourceDoneable;
-import io.javaoperatorsdk.operator.api.Context;
-import io.javaoperatorsdk.operator.api.Controller;
 import io.javaoperatorsdk.operator.api.ResourceController;
-import io.javaoperatorsdk.operator.api.UpdateControl;
-import io.fabric8.kubernetes.api.model.Secret;
-import io.fabric8.kubernetes.api.model.SecretBuilder;
-import io.fabric8.kubernetes.client.KubernetesClient;
-import org.apache.commons.lang3.RandomStringUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-
 import java.io.Serializable;
 
-import static java.lang.String.format;
 
+public abstract class AbstractController<T extends CustomResource> implements Serializable,
+    ResourceController<T> {
 
-public abstract class AbstractController implements Serializable, ResourceController<AbstractController.MyCustomResource> {
-    public static class MyCustomResource extends CustomResource {
+  public static class MyCustomResource extends CustomResource {
 
-    }
+  }
 }

operator-framework/src/test/resources/AdditionalControllerInterface.java

@@ -0,0 +1,11 @@
+package io;
+
+import io.fabric8.kubernetes.client.CustomResource;
+import io.javaoperatorsdk.operator.api.ResourceController;
+import java.io.Serializable;
+
+
+public interface AdditionalControllerInterface<R, T extends CustomResource> extends
+    Serializable,
+    ResourceController<T> {
+}

operator-framework/src/test/resources/ControllerImplementedIntermediateAbstractClass.java

@@ -16,13 +16,17 @@
 import static java.lang.String.format;
 
 @Controller(crdName = "test.crd")
-public class ControllerImplementedIntermediateAbstractClass extends AbstractController implements Serializable {
+public class ControllerImplementedIntermediateAbstractClass extends
+    AbstractController<AbstractController.MyCustomResource> implements Serializable {
 
-    public UpdateControl<AbstractController.MyCustomResource> createOrUpdateResource(AbstractController.MyCustomResource customResource, Context<AbstractController.MyCustomResource> context) {
-        return UpdateControl.updateCustomResource(null);
-    }
+  public UpdateControl<AbstractController.MyCustomResource> createOrUpdateResource(
+      AbstractController.MyCustomResource customResource,
+      Context<AbstractController.MyCustomResource> context) {
+    return UpdateControl.updateCustomResource(null);
+  }
 
-    public DeleteControl deleteResource(AbstractController.MyCustomResource customResource, Context<AbstractController.MyCustomResource> context) {
-        return DeleteControl.DEFAULT_DELETE;
-    }
+  public DeleteControl deleteResource(AbstractController.MyCustomResource customResource,
+      Context<AbstractController.MyCustomResource> context) {
+    return DeleteControl.DEFAULT_DELETE;
+  }
 }

operator-framework/src/test/resources/MultilevelAbstractController.java

@@ -0,0 +1,11 @@
+package io;
+
+import io.fabric8.kubernetes.client.CustomResource;
+import java.io.Serializable;
+
+
+public abstract class MultilevelAbstractController<R, T extends CustomResource> implements
+    Serializable,
+    AdditionalControllerInterface<R, T> {
+
+}

operator-framework/src/test/resources/MultilevelController.java

@@ -0,0 +1,28 @@
+package io;
+
+import io.fabric8.kubernetes.client.CustomResource;
+import io.javaoperatorsdk.operator.api.Context;
+import io.javaoperatorsdk.operator.api.Controller;
+import io.javaoperatorsdk.operator.api.DeleteControl;
+import io.javaoperatorsdk.operator.api.UpdateControl;
+
+@Controller(crdName = "test.crd")
+public class MultilevelController extends
+    MultilevelAbstractController<String, MultilevelController.MyCustomResource> {
+
+  public static class MyCustomResource extends CustomResource {
+
+  }
+
+  public UpdateControl<MultilevelController.MyCustomResource> createOrUpdateResource(
+      MultilevelController.MyCustomResource customResource,
+      Context<MultilevelController.MyCustomResource> context) {
+    return UpdateControl.updateCustomResource(null);
+  }
+
+  public DeleteControl deleteResource(MultilevelController.MyCustomResource customResource,
+      Context<MultilevelController.MyCustomResource> context) {
+    return DeleteControl.DEFAULT_DELETE;
+  }
+
+}

operator-framework/src/test/resources/MultilevelControllerExpected.java

@@ -0,0 +1,10 @@
+package io;
+
+import io.fabric8.kubernetes.api.builder.Function;
+import io.fabric8.kubernetes.client.CustomResourceDoneable;
+
+public class MyCustomResourceDoneable extends CustomResourceDoneable<MultilevelController.MyCustomResource> {
+    public MyCustomResourceDoneable(MultilevelController.MyCustomResource resource, Function function) {
+        super(resource, function);
+    }
+}