Skip to content

Commit e3f343b

Browse files
author
Soroosh Sarabadani
committed
Unit test customer finalizer name
1 parent 59345b6 commit e3f343b

File tree

1 file changed

+27
-3
lines changed

1 file changed

+27
-3
lines changed
Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
package io.javaoperatorsdk.operator;
22

3-
import io.javaoperatorsdk.operator.sample.TestCustomResource;
4-
import io.javaoperatorsdk.operator.sample.TestCustomResourceController;
53
import io.fabric8.kubernetes.client.CustomResourceDoneable;
4+
import io.javaoperatorsdk.operator.api.Context;
65
import io.javaoperatorsdk.operator.api.Controller;
6+
import io.javaoperatorsdk.operator.api.ResourceController;
7+
import io.javaoperatorsdk.operator.api.UpdateControl;
8+
import io.javaoperatorsdk.operator.sample.TestCustomResource;
9+
import io.javaoperatorsdk.operator.sample.TestCustomResourceController;
710
import org.junit.jupiter.api.Assertions;
811
import org.junit.jupiter.api.Test;
912

@@ -12,12 +15,33 @@
1215

1316
class ControllerUtilsTest {
1417

18+
public static final String CUSTOM_FINALIZER_NAME = "a.customer.finalizer";
19+
1520
@Test
1621
public void returnsValuesFromControllerAnnotationFinalizer() {
17-
Assertions.assertEquals(Controller.DEFAULT_FINALIZER, ControllerUtils.getDefaultFinalizer(new TestCustomResourceController(null)));
22+
Assertions.assertEquals(TestCustomResourceController.class.getCanonicalName(), ControllerUtils.getFinalizer(new TestCustomResourceController(null)));
1823
assertEquals(TestCustomResource.class, ControllerUtils.getCustomResourceClass(new TestCustomResourceController(null)));
1924
Assertions.assertEquals(TestCustomResourceController.CRD_NAME, ControllerUtils.getCrdName(new TestCustomResourceController(null)));
2025
assertEquals(false, ControllerUtils.getGenerationEventProcessing(new TestCustomResourceController(null)));
2126
assertTrue(CustomResourceDoneable.class.isAssignableFrom(ControllerUtils.getCustomResourceDoneableClass(new TestCustomResourceController(null))));
2227
}
28+
29+
@Controller(crdName = "test.crd", customResourceClass = TestCustomResource.class, finalizerName = CUSTOM_FINALIZER_NAME)
30+
static class TestCustomFinalizerController implements ResourceController<TestCustomResource> {
31+
32+
@Override
33+
public boolean deleteResource(TestCustomResource resource, Context<TestCustomResource> context) {
34+
return false;
35+
}
36+
37+
@Override
38+
public UpdateControl<TestCustomResource> createOrUpdateResource(TestCustomResource resource, Context<TestCustomResource> context) {
39+
return null;
40+
}
41+
}
42+
43+
@Test
44+
public void returnCustomerFinalizerNameIfSet() {
45+
assertEquals(CUSTOM_FINALIZER_NAME, ControllerUtils.getFinalizer(new TestCustomFinalizerController()));
46+
}
2347
}

0 commit comments

Comments
 (0)