Skip to content

Commit e9bde03

Browse files
committed
wip
Signed-off-by: Attila Mészáros <[email protected]>
1 parent 3f1a75b commit e9bde03

File tree

4 files changed

+33
-1
lines changed

4 files changed

+33
-1
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,8 @@ public void run() {
504504
return;
505505
}
506506
executionScope.setDeleteEvent(true);
507+
executionScope.setDeleteFinalStateUnknown(
508+
state.orElseThrow().isDeleteFinalStateUnknown());
507509
} else {
508510
log.debug("Skipping execution; primary resource missing from cache: {}", resourceID);
509511
return;

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ private PostExecutionControl<P> createPostExecutionControl(
262262
return postExecutionControl;
263263
}
264264

265-
// todo test
266265
private void updatePostExecutionControlWithReschedule(
267266
PostExecutionControl<P> postExecutionControl,
268267
BaseControl<?> baseControl,

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/EventProcessorTest.java

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,28 @@ void cleansUpForDeleteEventEvenIfProcessorNotStarted() {
491491
// no exception thrown
492492
}
493493

494+
@Test
495+
void allEventModeProcessesDeleteEvent() {}
496+
497+
@Test
498+
void allEventModeRetriesDeleteEventError() {}
499+
500+
@Test
501+
void processesAdditionalEventWhileInDeleteModeRetry() {}
502+
503+
@Test
504+
void allEventModeIfNoRetryInCleanupOnError() {
505+
}
506+
507+
@Test
508+
void onAllEventModeIfRetryExhaustedCleansUpState() {
509+
}
510+
511+
@Test
512+
void passesResourceFromStateToDispatcher() {
513+
// check also last state unknown
514+
}
515+
494516
private ResourceID eventAlreadyUnderProcessing() {
495517
when(reconciliationDispatcherMock.handleExecution(any()))
496518
.then(

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcherTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -703,6 +703,15 @@ void reconcilerContextUsesTheSameInstanceOfResourceAsParam() {
703703
.isNotSameAs(testCustomResource);
704704
}
705705

706+
@Test
707+
void allEventModeNoReSchedulesAllowedForDeleteEvent() {}
708+
709+
@Test
710+
void allEventModeCallsCleanupOnDeleteEvent() {}
711+
712+
@Test
713+
void allEventModeCallsCleanupOnMarkedForDeletion() {}
714+
706715
private ObservedGenCustomResource createObservedGenCustomResource() {
707716
ObservedGenCustomResource observedGenCustomResource = new ObservedGenCustomResource();
708717
observedGenCustomResource.setMetadata(new ObjectMeta());

0 commit comments

Comments
 (0)