chore: bump spotless 2.44.2 and format code #2661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
requested changes
Jan 8, 2025
| } | ||
| } | ||
| static boolean getBooleanFromSystemPropsOrDefault(String propertyName, | ||
| boolean defaultValue) {var property=System.getProperty(propertyName);if(property==null){return defaultValue;}else{property=property.trim().toLowerCase();return switch(property){case"true"->true;case"false"->false;default->defaultValue;};}} |
Collaborator
There was a problem hiding this comment.
Hmm, that doesn't seem right
Collaborator
Author
There was a problem hiding this comment.
wow, interesting, not sure, will take a look a look later, this might be a bug in spotless
Collaborator
Author
There was a problem hiding this comment.
even 2.44.2 is not fixing it we might want just ignore this for now, and create an issue for spotless?!
Collaborator
There was a problem hiding this comment.
Yes, there seems something wrong with 2.44
Signed-off-by: Attila Mészáros <[email protected]>
csviri
changed the title
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros [email protected]