diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Informer.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Informer.java index 3a425b786b..cdbf07a5c1 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Informer.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Informer.java @@ -13,7 +13,7 @@ import io.javaoperatorsdk.operator.processing.event.source.filter.OnDeleteFilter; import io.javaoperatorsdk.operator.processing.event.source.filter.OnUpdateFilter; -import static io.javaoperatorsdk.operator.api.reconciler.Constants.DEFAULT_FOLLOW_CONTROLLER_NAMESPACES_ON_CHANGE; +import static io.javaoperatorsdk.operator.api.reconciler.Constants.DEFAULT_FOLLOW_CONTROLLER_NAMESPACE_CHANGES; import static io.javaoperatorsdk.operator.api.reconciler.Constants.NO_LONG_VALUE_SET; import static io.javaoperatorsdk.operator.api.reconciler.Constants.NO_VALUE_SET; @@ -88,7 +88,7 @@ * Set that in case of a runtime controller namespace changes, the informer should also follow the * new namespace set. */ - boolean followControllerNamespacesOnChange() default DEFAULT_FOLLOW_CONTROLLER_NAMESPACES_ON_CHANGE; + boolean followControllerNamespaceChanges() default DEFAULT_FOLLOW_CONTROLLER_NAMESPACE_CHANGES; /** * Replaces the item store used by the informer for the associated primary resource controller. diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java index c9285e1cae..0c55353b86 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java @@ -29,7 +29,7 @@ public class InformerConfiguration { private final String resourceTypeName; private String name; private Set namespaces; - private Boolean followControllerNamespacesOnChange; + private Boolean followControllerNamespaceChanges; private String labelSelector; private OnAddFilter onAddFilter; private OnUpdateFilter onUpdateFilter; @@ -39,14 +39,14 @@ public class InformerConfiguration { private Long informerListLimit; protected InformerConfiguration(Class resourceClass, String name, Set namespaces, - boolean followControllerNamespacesOnChange, + boolean followControllerNamespaceChanges, String labelSelector, OnAddFilter onAddFilter, OnUpdateFilter onUpdateFilter, OnDeleteFilter onDeleteFilter, GenericFilter genericFilter, ItemStore itemStore, Long informerListLimit) { this(resourceClass); this.name = name; this.namespaces = namespaces; - this.followControllerNamespacesOnChange = followControllerNamespacesOnChange; + this.followControllerNamespaceChanges = followControllerNamespaceChanges; this.labelSelector = labelSelector; this.onAddFilter = onAddFilter; this.onUpdateFilter = onUpdateFilter; @@ -75,7 +75,7 @@ public static InformerConfiguration.Builder builder( public static InformerConfiguration.Builder builder( InformerConfiguration original) { return new InformerConfiguration(original.resourceClass, original.name, original.namespaces, - original.followControllerNamespacesOnChange, original.labelSelector, original.onAddFilter, + original.followControllerNamespaceChanges, original.labelSelector, original.onAddFilter, original.onUpdateFilter, original.onDeleteFilter, original.genericFilter, original.itemStore, original.informerListLimit).builder; } @@ -184,8 +184,8 @@ public Set getEffectiveNamespaces(ControllerConfiguration controllerC * * @return if namespace changes should be followed */ - public boolean isFollowControllerNamespacesOnChange() { - return followControllerNamespacesOnChange; + public boolean getFollowControllerNamespaceChanges() { + return followControllerNamespaceChanges; } /** @@ -258,7 +258,7 @@ public InformerConfiguration buildForController() { namespaces = Constants.DEFAULT_NAMESPACES_SET; } // to avoid potential NPE - followControllerNamespacesOnChange = false; + followControllerNamespaceChanges = false; return InformerConfiguration.this; } @@ -267,9 +267,9 @@ public InformerConfiguration build() { if (namespaces == null || namespaces.isEmpty()) { namespaces = Constants.SAME_AS_CONTROLLER_NAMESPACES_SET; } - if (followControllerNamespacesOnChange == null) { - followControllerNamespacesOnChange = - DEFAULT_FOLLOW_CONTROLLER_NAMESPACES_ON_CHANGE; + if (followControllerNamespaceChanges == null) { + followControllerNamespaceChanges = + DEFAULT_FOLLOW_CONTROLLER_NAMESPACE_CHANGES; } return InformerConfiguration.this; } @@ -304,8 +304,8 @@ public InformerConfiguration.Builder initFromAnnotation(Informer informerConf GenericFilter.class, context)); - withFollowControllerNamespacesOnChange( - informerConfig.followControllerNamespacesOnChange()); + withFollowControllerNamespacesChanges( + informerConfig.followControllerNamespaceChanges()); withItemStore(Utils.instantiate(informerConfig.itemStore(), ItemStore.class, context)); @@ -344,7 +344,7 @@ public Set namespaces() { * @return the builder instance so that calls can be chained fluently */ public Builder withNamespaces(Set namespaces, boolean followChanges) { - withNamespaces(namespaces).withFollowControllerNamespacesOnChange(followChanges); + withNamespaces(namespaces).withFollowControllerNamespacesChanges(followChanges); return this; } @@ -372,8 +372,8 @@ public Builder withWatchCurrentNamespace() { * controller's namespaces are reconfigured, {@code false} otherwise * @return the builder instance so that calls can be chained fluently */ - public Builder withFollowControllerNamespacesOnChange(boolean followChanges) { - InformerConfiguration.this.followControllerNamespacesOnChange = + public Builder withFollowControllerNamespacesChanges(boolean followChanges) { + InformerConfiguration.this.followControllerNamespaceChanges = followChanges; return this; } diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java index ca40762e7a..d0ee1f1cf0 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerEventSourceConfiguration.java @@ -35,7 +35,7 @@ static Builder from( * @return if namespace changes should be followed */ default boolean followControllerNamespaceChanges() { - return getInformerConfig().isFollowControllerNamespacesOnChange(); + return getInformerConfig().getFollowControllerNamespaceChanges(); } /** @@ -194,8 +194,8 @@ public void updateFrom(InformerConfiguration informerConfig) { this.name = informerConfigName; } config.withNamespaces(informerConfig.getNamespaces()) - .withFollowControllerNamespacesOnChange( - informerConfig.isFollowControllerNamespacesOnChange()) + .withFollowControllerNamespacesChanges( + informerConfig.getFollowControllerNamespaceChanges()) .withLabelSelector(informerConfig.getLabelSelector()) .withItemStore(informerConfig.getItemStore()) .withOnAddFilter(informerConfig.getOnAddFilter()) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java index 8003d8f836..0b0438bc23 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java @@ -25,7 +25,7 @@ public final class Constants { public static final String RESOURCE_GVK_KEY = "josdk.resource.gvk"; public static final String CONTROLLER_NAME = "controller.name"; - public static final boolean DEFAULT_FOLLOW_CONTROLLER_NAMESPACES_ON_CHANGE = true; + public static final boolean DEFAULT_FOLLOW_CONTROLLER_NAMESPACE_CHANGES = true; private Constants() {} } diff --git a/operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java b/operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java index 19fa6a324c..2857ab9335 100644 --- a/operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java +++ b/operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/InformerConfigurationTest.java @@ -47,8 +47,7 @@ void currentNamespaceWatched() { @Test void nullLabelSelectorByDefault() { - final var informerConfig = - InformerConfiguration.builder(ConfigMap.class).build(); + final var informerConfig = InformerConfiguration.builder(ConfigMap.class).build(); assertNull(informerConfig.getLabelSelector()); } @@ -60,9 +59,8 @@ void shouldWatchAllNamespacesByDefaultForControllers() { @Test void shouldFollowControllerNamespacesByDefaultForInformerEventSource() { - final var informerConfig = - InformerConfiguration.builder(ConfigMap.class).build(); - assertTrue(informerConfig.isFollowControllerNamespacesOnChange()); + final var informerConfig = InformerConfiguration.builder(ConfigMap.class).build(); + assertTrue(informerConfig.getFollowControllerNamespaceChanges()); } @Test